Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932649Ab3CQPMA (ORCPT ); Sun, 17 Mar 2013 11:12:00 -0400 Received: from cantor2.suse.de ([195.135.220.15]:54978 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932096Ab3CQPL7 (ORCPT ); Sun, 17 Mar 2013 11:11:59 -0400 Date: Sun, 17 Mar 2013 15:11:55 +0000 From: Mel Gorman To: Andi Kleen Cc: Linux-MM , Jiri Slaby , Valdis Kletnieks , Rik van Riel , Zlatko Calusic , Johannes Weiner , dormando , Satoru Moriya , Michal Hocko , LKML Subject: Re: [PATCH 06/10] mm: vmscan: Have kswapd writeback pages based on dirty pages encountered, not priority Message-ID: <20130317151155.GC2026@suse.de> References: <1363525456-10448-1-git-send-email-mgorman@suse.de> <1363525456-10448-7-git-send-email-mgorman@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1328 Lines: 41 On Sun, Mar 17, 2013 at 07:42:39AM -0700, Andi Kleen wrote: > Mel Gorman writes: > > > @@ -495,6 +495,9 @@ typedef enum { > > ZONE_CONGESTED, /* zone has many dirty pages backed by > > * a congested BDI > > */ > > + ZONE_DIRTY, /* reclaim scanning has recently found > > + * many dirty file pages > > + */ > > Needs a better name. ZONE_DIRTY_CONGESTED ? > That might be confusing. The underlying BDI is not necessarily congested. I accept your point though and will try thinking of a better name. > > + * currently being written then flag that kswapd should start > > + * writing back pages. > > + */ > > + if (global_reclaim(sc) && nr_dirty && > > + nr_dirty >= (nr_taken >> (DEF_PRIORITY - sc->priority))) > > + zone_set_flag(zone, ZONE_DIRTY); > > + > > trace_mm_vmscan_lru_shrink_inactive(zone->zone_pgdat->node_id, > > I suppose you want to trace the dirty case here too. > I guess it wouldn't hurt to have a new tracepoint for when the flag gets set. A vmstat might be helpful as well. -- Mel Gorman SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/