Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756516Ab3CQPt4 (ORCPT ); Sun, 17 Mar 2013 11:49:56 -0400 Received: from ch1ehsobe005.messaging.microsoft.com ([216.32.181.185]:24046 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756247Ab3CQPtw convert rfc822-to-8bit (ORCPT ); Sun, 17 Mar 2013 11:49:52 -0400 X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI X-SpamScore: -3 X-BigFish: VS-3(zz98dI9371I542I1432Izz1f42h1ee6h1de0h1202h1e76h1d1ah1d2ahzzz2dh2a8h668h839h8e2h8e3h944hd25hf0ah1220h1288h12a5h12a9h12bdh137ah13b6h1441h1504h1537h153bh15d0h162dh1631h1758h18e1h1946h19b5h1ad9h1b0ahbe9i1155h) From: Sethi Varun-B16395 To: Yoder Stuart-B08248 , Kumar Gala CC: "joro@8bytes.org" , "iommu@lists.linux-foundation.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "benh@kernel.crashing.org" , Wood Scott-B07421 Subject: RE: [PATCH 5/5 v9] iommu/fsl: Freescale PAMU driver and iommu implementation. Thread-Topic: [PATCH 5/5 v9] iommu/fsl: Freescale PAMU driver and iommu implementation. Thread-Index: AQHOIPj41zV+T3rtGkKRKb3aevxXyZiqDBZA Date: Sun, 17 Mar 2013 15:49:47 +0000 Message-ID: References: <1363200580-11623-1-git-send-email-Varun.Sethi@freescale.com> <0080B56D-8417-41B9-8341-665457D04DE6@kernel.crashing.org> <9F6FE96B71CF29479FF1CDC8046E1503586936@039-SN1MPN1-002.039d.mgd.msft.net> In-Reply-To: <9F6FE96B71CF29479FF1CDC8046E1503586936@039-SN1MPN1-002.039d.mgd.msft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.214.249.193] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1820 Lines: 54 > -----Original Message----- > From: Yoder Stuart-B08248 > Sent: Friday, March 15, 2013 2:45 AM > To: Kumar Gala; Sethi Varun-B16395 > Cc: joro@8bytes.org; iommu@lists.linux-foundation.org; linuxppc- > dev@lists.ozlabs.org; linux-kernel@vger.kernel.org; > benh@kernel.crashing.org; Wood Scott-B07421 > Subject: RE: [PATCH 5/5 v9] iommu/fsl: Freescale PAMU driver and iommu > implementation. > > > > > -----Original Message----- > > From: Kumar Gala [mailto:galak@kernel.crashing.org] > > Sent: Thursday, March 14, 2013 3:20 PM > > To: Sethi Varun-B16395 > > Cc: joro@8bytes.org; iommu@lists.linux-foundation.org; > > linuxppc-dev@lists.ozlabs.org; linux- kernel@vger.kernel.org; > > benh@kernel.crashing.org; Wood Scott-B07421; Yoder Stuart-B08248 > > Subject: Re: [PATCH 5/5 v9] iommu/fsl: Freescale PAMU driver and iommu > implementation. > > > > > > On Mar 13, 2013, at 1:49 PM, Varun Sethi wrote: > > > > > +/* > > > + * Table of SVRs and the corresponding PORT_ID values. > > > + * > > > + * All future CoreNet-enabled SOCs will have this erratum fixed, so > > > +this table > > > + * should never need to be updated. SVRs are guaranteed to be > > > +unique, so > > > + * there is no worry that a future SOC will inadvertently have one > > > +of these > > > + * values. > > > + */ > > > > Maybe add to the comment about what port_id represents > > When you update the comment, I would also suggest identifying the > specific errata here (A-004510) so that it's easy to reference back to > the specific issue this code is fixing. [Sethi Varun-B16395] Ok -Varun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/