Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932627Ab3CQV06 (ORCPT ); Sun, 17 Mar 2013 17:26:58 -0400 Received: from ozlabs.org ([203.10.76.45]:34634 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932325Ab3CQV0z (ORCPT ); Sun, 17 Mar 2013 17:26:55 -0400 Date: Mon, 18 Mar 2013 08:26:48 +1100 From: Paul Mackerras To: Lai Jiangshan Cc: "Paul E. McKenney" , Andrew Morton , linux-kernel@vger.kernel.org, Marcelo Tosatti , Gleb Natapov , Alexander Graf , Benjamin Herrenschmidt , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 1/9] powerpc,kvm: fix imbalance srcu_read_[un]lock() Message-ID: <20130317212648.GA4259@iris.ozlabs.ibm.com> References: <1363366257-4886-1-git-send-email-laijs@cn.fujitsu.com> <1363366257-4886-2-git-send-email-laijs@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1363366257-4886-2-git-send-email-laijs@cn.fujitsu.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1269 Lines: 35 On Sat, Mar 16, 2013 at 12:50:49AM +0800, Lai Jiangshan wrote: > At the point of up_out label in kvmppc_hv_setup_htab_rma(), > srcu read lock is still held. > > We have to release it before return. > > Signed-off-by: Lai Jiangshan > Cc: Marcelo Tosatti > Cc: Gleb Natapov > Cc: Alexander Graf > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: kvm@vger.kernel.org > Cc: kvm-ppc@vger.kernel.org > --- > arch/powerpc/kvm/book3s_hv.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c > index 80dcc53..c26740e 100644 > --- a/arch/powerpc/kvm/book3s_hv.c > +++ b/arch/powerpc/kvm/book3s_hv.c > @@ -1799,7 +1799,7 @@ static int kvmppc_hv_setup_htab_rma(struct kvm_vcpu *vcpu) > > up_out: > up_read(¤t->mm->mmap_sem); > - goto out; > + goto out_srcu; Acked-by: Paul Mackerras -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/