Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753350Ab3CRJKw (ORCPT ); Mon, 18 Mar 2013 05:10:52 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56912 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752102Ab3CRJKr (ORCPT ); Mon, 18 Mar 2013 05:10:47 -0400 Date: Mon, 18 Mar 2013 10:10:45 +0100 Message-ID: From: Takashi Iwai To: Daniel Vetter Cc: Daniel Vetter , Paulo Zanoni , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "drm/i915: try to train DP even harder" In-Reply-To: <20130317215922.GH9021@phenom.ffwll.local> References: <20130317215922.GH9021@phenom.ffwll.local> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1219 Lines: 34 At Sun, 17 Mar 2013 22:59:22 +0100, Daniel Vetter wrote: > > On Mon, Mar 11, 2013 at 06:40:16PM +0100, Takashi Iwai wrote: > > This reverts commit 0d71068835e2610576d369d6d4cbf90e0f802a71. > > > > Not only that the commit introduces a bogus check (voltage_tries == 5 > > will never meet at the inserted code path), it brings the i915 driver > > into an endless dp-train loop on HP Z1 desktop machine with IVY+eDP. > > > > At least reverting this commit recovers the framebuffer (but X is > > still broken by other reasons...) > > > > Cc: > > Signed-off-by: Takashi Iwai > Picked up for -fixes, thanks for the patch. Thanks! > Adding Paulo since it's his > patch. To assign proper blame please cc: relevant people when sending out > reverts. Well, Paulo was on Cc in the first post, but I dropped in the next patch series since I've got no reply since then. (And intel-gfx was on Cc, so he could read it anyway...) Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/