Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753783Ab3CRLAD (ORCPT ); Mon, 18 Mar 2013 07:00:03 -0400 Received: from moutng.kundenserver.de ([212.227.17.8]:60618 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753733Ab3CRK76 (ORCPT ); Mon, 18 Mar 2013 06:59:58 -0400 From: Arnd Bergmann To: Fabio Porcedda Subject: Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe() Date: Mon, 18 Mar 2013 10:58:51 +0000 User-Agent: KMail/1.12.2 (Linux/3.8.0-8-generic; KDE/4.3.2; x86_64; ; ) Cc: H Hartley Sweeten , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" , "linux-ide@vger.kernel.org" , "lm-sensors@lm-sensors.org" , "linux-input@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "Greg Kroah-Hartman" , "Hans-Christian Egtvedt" , Grant Likely References: <1363266691-15757-1-git-send-email-fabio.porcedda@gmail.com> <201303152018.09094.arnd@arndb.de> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201303181058.51641.arnd@arndb.de> X-Provags-ID: V02:K0:0cL2cpQkGf/y11WD24WigC1LF5VkprWZqmGpzut/3OJ fSjD8nZnOiRXFQYEda9RXzUSqmsWQMFVYdOCeTsgKy6dJ8fWi4 tqPKgNCBdy7FS7BCvXbwhWdHcPZ4C1xa/JhKxfRbqlryKPeGK3 3WHKlyHTs0foV6Zj4++alEpu2eLVDkHJmZ+hfHFZCdiudo8hEk Jxv11/CmdF/J/zKrrMM+Xvy9f8Iz83EJwRQTBqzxWSRjtnbByr hKPhed019FuGWgEPKjBcLFgiDilC/eXazrNzlsIfnga+lzUi3u wkJa6c4eDsn63WHy8YFoa//7P484ZllJuAQlUYdRZzwASamk3j 7AT8aixX2MCzJDhR2apc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 735 Lines: 17 On Monday 18 March 2013, Fabio Porcedda wrote: > Since by using platform_driver_probe() the function > ep93xx_pwm_probe() is freed after initialization, > is better to use module_platform_drive_probe(). > IMHO i don't see any good reason to use module_platform_driver() for > this driver. As I commented earlier, the platform_driver_probe() and module_platform_drive_probe() interfaces are rather dangerous in combination with deferred probing, I would much prefer Harley's patch. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/