Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752949Ab3CRL3D (ORCPT ); Mon, 18 Mar 2013 07:29:03 -0400 Received: from moutng.kundenserver.de ([212.227.126.186]:56742 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752471Ab3CRL24 (ORCPT ); Mon, 18 Mar 2013 07:28:56 -0400 From: Arnd Bergmann To: Fabio Porcedda Subject: Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe() Date: Mon, 18 Mar 2013 11:28:45 +0000 User-Agent: KMail/1.12.2 (Linux/3.8.0-8-generic; KDE/4.3.2; x86_64; ; ) Cc: H Hartley Sweeten , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" , "linux-ide@vger.kernel.org" , "lm-sensors@lm-sensors.org" , "linux-input@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "Greg Kroah-Hartman" , "Hans-Christian Egtvedt" , Grant Likely References: <1363266691-15757-1-git-send-email-fabio.porcedda@gmail.com> <201303181058.51641.arnd@arndb.de> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201303181128.45215.arnd@arndb.de> X-Provags-ID: V02:K0:YvHE9MSMPOuuspu0/fSAbfFMHDt1Noq0RTkUorGPUnp mVfS8tsRQVmCEHj91S6bs/mB2dOMPeF187vQa/lWYJ1tOyalYU jWWT658Wlh2C81HDI0sVMUJaFOEJftCHQ4oBOJaWR03//I104+ hO91Fcfze6J77bBU5BX9uVb5aSmB24YZCjyPBCE+QovsM9HySz hhrN4YZcTzMMm3RiAfmMMKdW846Xb+3g7ynP/ktJAnwaXC/G8v 9OOq4fTwoE5AihNaCmCaoIgSkwg+o29tu43jCeDFCO/J1Zv8Lt 8x/5Cn1jOWsBzcavGM08YRDrpjE9nbgCyC/MfWf9gsuqG78EZ1 BfOB1K/KZydg9cqvZm0w= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1271 Lines: 29 On Monday 18 March 2013, Fabio Porcedda wrote: > > On Mon, Mar 18, 2013 at 11:58 AM, Arnd Bergmann wrote: > > On Monday 18 March 2013, Fabio Porcedda wrote: > >> Since by using platform_driver_probe() the function > >> ep93xx_pwm_probe() is freed after initialization, > >> is better to use module_platform_drive_probe(). > >> IMHO i don't see any good reason to use module_platform_driver() for > >> this driver. > > > > As I commented earlier, the platform_driver_probe() and > > module_platform_drive_probe() interfaces are rather dangerous in combination > > with deferred probing, I would much prefer Harley's patch. > > Since those drivers don't use -EPROBE_DEFER i was thinking that they don't use > deferred probing. > I'm missing something? clk_get() may return -EPROBE_DEFER after ep93xx is converted to use the common clk API. We currently return the value of clk_get from the probe() function, which will automatically do the right thing as long as the probe function remains reachable. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/