Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753394Ab3CRMC0 (ORCPT ); Mon, 18 Mar 2013 08:02:26 -0400 Received: from mail-ob0-f178.google.com ([209.85.214.178]:42363 "EHLO mail-ob0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752091Ab3CRMCZ convert rfc822-to-8bit (ORCPT ); Mon, 18 Mar 2013 08:02:25 -0400 MIME-Version: 1.0 In-Reply-To: <1363607942.14386.73.camel@kjgkr> References: <1363585931-8441-1-git-send-email-jaegeuk.kim@samsung.com> <1363607942.14386.73.camel@kjgkr> Date: Mon, 18 Mar 2013 21:02:24 +0900 Message-ID: Subject: Re: [PATCH 13/19] f2fs: fix return value of releasepage for node and data From: Namjae Jeon To: jaegeuk.kim@samsung.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1496 Lines: 45 2013/3/18, Jaegeuk Kim : > 2013-03-18 (월), 20:39 +0900, Namjae Jeon: >> 2013/3/18, Jaegeuk Kim : >> > If the return value of releasepage is equal to zero, the page cannot be >> > reclaimed. >> > Instead, we should return 1 in order to reclaim clean pages. >> > >> > Signed-off-by: Jaegeuk Kim >> > --- >> > fs/f2fs/data.c | 4 +++- >> > fs/f2fs/node.c | 13 +++---------- >> > 2 files changed, 6 insertions(+), 11 deletions(-) >> > >> > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c >> > index 6616137..cd6b2cc 100644 >> > --- a/fs/f2fs/data.c >> > +++ b/fs/f2fs/data.c >> > @@ -680,8 +680,10 @@ static void f2fs_invalidate_data_page(struct page >> > *page, unsigned long offset) >> > >> > static int f2fs_release_data_page(struct page *page, gfp_t wait) >> > { >> > + if (PageWriteback(page)) >> > + return 0; >> > ClearPagePrivate(page); >> > - return 0; >> > + return 1; >> > } >> I have a question. >> Although PageWriteback is already checked in try_to_release_page, >> we need to check it again in f2fs_release_data_page ? > > Oh, I made a mistake. > No need to check that. > Thanks, You can add Reviewed-by: Namjae Jeon Thanks :) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/