Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753412Ab3CRMJ3 (ORCPT ); Mon, 18 Mar 2013 08:09:29 -0400 Received: from wolverine01.qualcomm.com ([199.106.114.254]:12007 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752115Ab3CRMJ1 (ORCPT ); Mon, 18 Mar 2013 08:09:27 -0400 X-IronPort-AV: E=Sophos;i="4.84,865,1355126400"; d="scan'208";a="30279932" X-IronPort-AV: E=Sophos;i="4.84,865,1355126400"; d="scan'208";a="418885370" From: Kalle Valo To: Andrei Epure CC: , , , Subject: Re: [PATCH] ath: changed kmalloc to kmemdup References: <1362919199-16292-1-git-send-email-epure.andrei@gmail.com> Date: Mon, 18 Mar 2013 14:09:22 +0200 In-Reply-To: <1362919199-16292-1-git-send-email-epure.andrei@gmail.com> (Andrei Epure's message of "Sun, 10 Mar 2013 14:39:58 +0200") Message-ID: <878v5k9afh.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" X-Originating-IP: [172.30.48.1] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1014 Lines: 32 Andrei Epure writes: > Signed-off-by: Andrei Epure > --- > drivers/net/wireless/ath/ath6kl/usb.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath6kl/usb.c b/drivers/net/wireless/ath/ath6kl/usb.c > index 5fcd342..ffa1daa 100644 > --- a/drivers/net/wireless/ath/ath6kl/usb.c > +++ b/drivers/net/wireless/ath/ath6kl/usb.c > @@ -856,11 +856,9 @@ static int ath6kl_usb_submit_ctrl_out(struct ath6kl_usb *ar_usb, > int ret; > > if (size > 0) { > - buf = kmalloc(size, GFP_KERNEL); > + buf = kmemdup(data, size, GFP_KERNEL); > if (buf == NULL) > return -ENOMEM; > - > - memcpy(buf, data, size); > } Thanks, applied to ath6kl.git. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/