Message-id: <5148316D.9040801@samsung.com>
Date: Tue, 19 Mar 2013 18:35:41 +0900
From: Chanwoo Choi <cw00.choi@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106
 Thunderbird/17.0.2
MIME-version: 1.0
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-kernel@vger.kernel.org, myungjoo.ham@samsung.com
Subject: Re: [PATCH 1/1] extcon: max77693: Staticize default_init_data
References: <1363666036-14006-1-git-send-email-sachin.kamat@linaro.org>
In-reply-to: <1363666036-14006-1-git-send-email-sachin.kamat@linaro.org>
Content-type: text/plain; charset=ISO-8859-1
Content-transfer-encoding: 7bit
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1352
Lines: 34

On 03/19/2013 01:07 PM, Sachin Kamat wrote:
> Commit 0ec83bd246 ("extcon: max77693: Initialize register of MUIC
> device to bring up it without platform data") added this structure
> but forgot to make it static. Without this patch we get the following
> warning:
> drivers/extcon/extcon-max77693.c:41:26: warning:
> symbol 'default_init_data' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/extcon/extcon-max77693.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c
> index 8f3c947..7b2e93d 100644
> --- a/drivers/extcon/extcon-max77693.c
> +++ b/drivers/extcon/extcon-max77693.c
> @@ -38,7 +38,7 @@
>   * extcon-max77693 driver use 'default_init_data' to bring up base operation
>   * of MAX77693 MUIC device.
>   */
> -struct max77693_reg_data default_init_data[] = {
> +static struct max77693_reg_data default_init_data[] = {
>  	{
>  		/* STATUS2 - [3]ChgDetRun */
>  		.addr = MAX77693_MUIC_REG_STATUS2,
Applied it. Thanks.

Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/