Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933597Ab3CSJzW (ORCPT ); Tue, 19 Mar 2013 05:55:22 -0400 Received: from cantor2.suse.de ([195.135.220.15]:57557 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753531Ab3CSJzT (ORCPT ); Tue, 19 Mar 2013 05:55:19 -0400 Date: Tue, 19 Mar 2013 09:55:15 +0000 From: Mel Gorman To: Simon Jeons Cc: Linux-MM , Jiri Slaby , Valdis Kletnieks , Rik van Riel , Zlatko Calusic , Johannes Weiner , dormando , Satoru Moriya , Michal Hocko , LKML Subject: Re: [PATCH 01/10] mm: vmscan: Limit the number of pages kswapd reclaims at each priority Message-ID: <20130319095514.GA2055@suse.de> References: <1363525456-10448-1-git-send-email-mgorman@suse.de> <1363525456-10448-2-git-send-email-mgorman@suse.de> <5147A8EC.5010908@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <5147A8EC.5010908@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1296 Lines: 28 On Tue, Mar 19, 2013 at 07:53:16AM +0800, Simon Jeons wrote: > Hi Mel, > On 03/17/2013 09:04 PM, Mel Gorman wrote: > >The number of pages kswapd can reclaim is bound by the number of pages it > >scans which is related to the size of the zone and the scanning priority. In > >many cases the priority remains low because it's reset every SWAP_CLUSTER_MAX > >reclaimed pages but in the event kswapd scans a large number of pages it > >cannot reclaim, it will raise the priority and potentially discard a large > >percentage of the zone as sc->nr_to_reclaim is ULONG_MAX. The user-visible > >effect is a reclaim "spike" where a large percentage of memory is suddenly > >freed. It would be bad enough if this was just unused memory but because > > Since there is nr_reclaimed >= nr_to_reclaim check if priority is > large than DEF_PRIORITY in shrink_lruvec, how can a large percentage > of memory is suddenly freed happen? > Because of the priority checks made in get_scan_count(). Patch 5 has more detail on why this happens. -- Mel Gorman SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/