Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934233Ab3CSVME (ORCPT ); Tue, 19 Mar 2013 17:12:04 -0400 Received: from out03.mta.xmission.com ([166.70.13.233]:41325 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542Ab3CSVMC (ORCPT ); Tue, 19 Mar 2013 17:12:02 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: HATAYAMA Daisuke Cc: vgoyal@redhat.com, cpw@sgi.com, kumagai-atsushi@mxc.nes.nec.co.jp, lisa.mitchell@hp.com, heiko.carstens@de.ibm.com, akpm@linux-foundation.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, zhangyanfei@cn.fujitsu.com References: <20130316040003.15064.62308.stgit@localhost6.localdomain6> <20130316040223.15064.77472.stgit@localhost6.localdomain6> Date: Tue, 19 Mar 2013 14:11:51 -0700 In-Reply-To: <20130316040223.15064.77472.stgit@localhost6.localdomain6> (HATAYAMA Daisuke's message of "Sat, 16 Mar 2013 13:02:23 +0900") Message-ID: <87ppyvp014.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-AID: U2FsdGVkX1+GPqS01qDeWLS2AbYk+SHtdV6TsSSmcCI= X-SA-Exim-Connect-IP: 98.207.154.105 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.1 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: T_TM2_M_HEADER_IN_MSG * -3.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa06 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa06 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;HATAYAMA Daisuke X-Spam-Relay-Country: Subject: Re: [PATCH v3 17/21] vmcore: check NT_VMCORE_PAD as a mark indicating the end of ELF note buffer X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Wed, 14 Nov 2012 14:26:46 -0700) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 905 Lines: 21 HATAYAMA Daisuke writes: > Modern kernel marks the end of ELF note buffer with NT_VMCORE_PAD type > note in order to make the buffer satisfy mmap()'s page-size boundary > requirement. This patch makes finishing reading each buffer if the > note type now being read is NT_VMCORE_PAD type. Ick. Even with a pad header you can mark the end with an empty header, and my memory may be deceiving me but I believe an empty header is specified by the ELF ABI docs. Beyond which I don't quite see the point of any of this as all of these headers need to be combined into a single note section before being presented to user space. Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/