Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757505Ab3CTBOy (ORCPT ); Tue, 19 Mar 2013 21:14:54 -0400 Received: from LGEMRELSE1Q.lge.com ([156.147.1.111]:64921 "EHLO LGEMRELSE1Q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753258Ab3CTBOx (ORCPT ); Tue, 19 Mar 2013 21:14:53 -0400 X-AuditID: 9c93016f-b7b08ae000000bbd-ab-51490d8b86a2 From: Namhyung Kim To: Steven Rostedt Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Paul Mackerras , Ingo Molnar , Namhyung Kim , LKML , Frederic Weisbecker Subject: Re: [PATCH 6/9] perf util: Get rid of malloc_or_die() in trace-event-read.c References: <1363683224-28804-1-git-send-email-namhyung@kernel.org> <1363683224-28804-7-git-send-email-namhyung@kernel.org> <1363704602.5938.26.camel@gandalf.local.home> Date: Wed, 20 Mar 2013 10:14:51 +0900 In-Reply-To: <1363704602.5938.26.camel@gandalf.local.home> (Steven Rostedt's message of "Tue, 19 Mar 2013 10:50:02 -0400") Message-ID: <87ehfaj2ic.fsf@sejong.aot.lge.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1050 Lines: 31 On Tue, 19 Mar 2013 10:50:02 -0400, Steven Rostedt wrote: > On Tue, 2013-03-19 at 17:53 +0900, Namhyung Kim wrote: >> free(version); >> @@ -331,11 +354,12 @@ ssize_t trace_report(int fd, struct pevent **ppevent, bool __repipe) >> >> page_size = read4(pevent); >> >> - read_header_files(pevent); >> - read_ftrace_files(pevent); >> - read_event_files(pevent); >> - read_proc_kallsyms(pevent); >> - read_ftrace_printk(pevent); >> + if (read_header_files(pevent) || >> + read_ftrace_files(pevent) || >> + read_event_files(pevent) || >> + read_proc_kallsyms(pevent) || >> + read_ftrace_printk(pevent)) >> + goto out; > > I think I like the err += func() and check for err < 0, better. Okay, I'll change them to err |= func() style if you're fine as Peter suggested. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/