Date: Wed, 20 Mar 2013 09:52:41 +0100
From: Samuel Ortiz <sameo@linux.intel.com>
To: Simon Glass <sjg@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Rob Landley <rob@landley.net>,
        Felipe Balbi <balbi@ti.com>, Grant Likely <grant.likely@secretlab.ca>,
        Wolfram Sang <w.sang@pengutronix.de>,
        Luigi Semenzato <semenzato@chromium.org>,
        Rob Herring <rob.herring@calxeda.com>,
        Che-Liang Chiou <clchiou@chromium.org>,
        Jonathan Kliegman <kliegs@chromium.org>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
        Sourav Poddar <sourav.poddar@ti.com>,
        Devicetree Discuss <devicetree-discuss@lists.ozlabs.org>,
        Alban Bedel <alban.bedel@avionic-design.de>,
        Roland Stigge <stigge@antcom.de>,
        Vincent Palatin <vpalatin@chromium.org>,
        Javier Martinez Canillas <javier@dowhile0.org>,
        Mark Brown <broonie@opensource.wolfsonmicro.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Tony Lindgren <tony@atomide.com>, Bill Pemberton <wfp5p@virginia.edu>
Subject: Re: [PATCH v6 0/6] Add ChromeOS Embedded Controller support
Message-ID: <20130320085241.GA10570@zurbaran>
References: <1361830121-32284-1-git-send-email-sjg@chromium.org>
 <20130320005652.GC26903@zurbaran>
 <20130320011211.GA5905@zurbaran>
 <CAPnjgZ1=w5GyfGrSFG63SFTErTQQUQQiBmgC8BVMzy4kLVkPDg@mail.gmail.com>
 <20130320081456.GA5939@zurbaran>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20130320081456.GA5939@zurbaran>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1750
Lines: 41

Hi Simon,

On Wed, Mar 20, 2013 at 09:14:56AM +0100, Samuel Ortiz wrote:
> On Tue, Mar 19, 2013 at 07:01:42PM -0700, Simon Glass wrote:
> > Hi Samuel,
> > 
> > On Tue, Mar 19, 2013 at 6:12 PM, Samuel Ortiz <sameo@linux.intel.com> wrote:
> > > On Wed, Mar 20, 2013 at 01:56:52AM +0100, Samuel Ortiz wrote:
> > >> Hi Simon,
> > >>
> > >> On Mon, Feb 25, 2013 at 02:08:35PM -0800, Simon Glass wrote:
> > >> > The ChromeOS Embedded Controller (EC) is an Open Source EC implementation
> > >> > used on ARM and Intel Chromebooks. Current implementations use a Cortex-M3
> > >> > connected on a bus (such as I2C, SPI, LPC) to the AP. A separate interrupt
> > >> > line is used to indicate when the EC needs service.
> > >> All 6 patches applied to my mfd-next tree, thanks a lot.
> > > Actually, this one fails to build when CONFIG_OF is not set:
> > >
> > > drivers/mfd/cros_ec_i2c.c:130:2: error: implicit declaration of function
> > > ‘of_device_is_available’ [-Werror=implicit-function-declaration]
> > >
> > > If the check in cros_ec_probe_i2c() is really needed then you'll need to inline
> > > of_device_is_available() into a NOP in include/linux/of.h.
> > 
> > Actually I suppose that call is not really needed. Would you like to
> > remove it, or shall I send a new patch?
> I will remove it.
This is fixed and pushed. I also fixed some warnings and another build failure
for the case when all of your code is modular.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/