Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758202Ab3CTMYe (ORCPT ); Wed, 20 Mar 2013 08:24:34 -0400 Received: from hqemgate03.nvidia.com ([216.228.121.140]:9969 "EHLO hqemgate03.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756568Ab3CTMYd convert rfc822-to-8bit (ORCPT ); Wed, 20 Mar 2013 08:24:33 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Wed, 20 Mar 2013 05:17:18 -0700 From: Venu Byravarasu To: Stephen Warren CC: "gregkh@linuxfoundation.org" , "stern@rowland.harvard.edu" , "balbi@ti.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" Date: Wed, 20 Mar 2013 17:54:27 +0530 Subject: RE: [PATCH 3/7] usb: phy: tegra: Get PHY mode using DT Thread-Topic: [PATCH 3/7] usb: phy: tegra: Get PHY mode using DT Thread-Index: Ac4k3DAeU9KLMvJaTlSOUIrztSXm3AAiaK2w Message-ID: References: <1363609781-4045-1-git-send-email-vbyravarasu@nvidia.com> <1363609781-4045-4-git-send-email-vbyravarasu@nvidia.com> <5148C367.6050606@wwwdotorg.org> In-Reply-To: <5148C367.6050606@wwwdotorg.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1560 Lines: 41 > -----Original Message----- > From: Stephen Warren [mailto:swarren@wwwdotorg.org] > Sent: Wednesday, March 20, 2013 1:29 AM > To: Venu Byravarasu > Cc: gregkh@linuxfoundation.org; stern@rowland.harvard.edu; > balbi@ti.com; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-tegra@vger.kernel.org; devicetree-discuss@lists.ozlabs.org > Subject: Re: [PATCH 3/7] usb: phy: tegra: Get PHY mode using DT > > On 03/18/2013 06:29 AM, Venu Byravarasu wrote: > > Added a new PHY mode to support OTG. > > Obtained Tegra USB PHY mode using DT property. > > > diff --git a/drivers/usb/phy/tegra_usb_phy.c > b/drivers/usb/phy/tegra_usb_phy.c > > > @@ -713,6 +712,16 @@ struct tegra_usb_phy > *tegra_usb_phy_open(struct device *dev, int instance, > > else > > phy->is_ulpi_phy = true; > > > > + err = of_property_match_string(np, "dr_mode", "otg"); > > + if (err < 0) { > > + err = of_property_match_string(np, "dr_mode", "gadget"); > > + if (err < 0) > > The binding says the 3 legal values for this property are "host", > "peripheral", or "otg". This agrees with the usage in > Documentation/devicetree/bindings/usb/fsl-usb.txt and > drivers/usb/host/fsl-mph-dr-of.c. So, "gadget" is not something the code > should be checking for. Agree, will correct it. > > I'm sure I pointed this out before. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/