Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755390Ab3CTNsi (ORCPT ); Wed, 20 Mar 2013 09:48:38 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:37362 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755162Ab3CTNsg (ORCPT ); Wed, 20 Mar 2013 09:48:36 -0400 MIME-Version: 1.0 In-Reply-To: <1363783096.3724.5.camel@laptop> References: <1360820921-2513-1-git-send-email-iamjoonsoo.kim@lge.com> <1360820921-2513-8-git-send-email-iamjoonsoo.kim@lge.com> <1363705546.22553.61.camel@laptop> <20130320074330.GE11672@lge.com> <1363783096.3724.5.camel@laptop> Date: Wed, 20 Mar 2013 22:48:32 +0900 Message-ID: Subject: Re: [PATCH 7/8] sched: prevent to re-select dst-cpu in load_balance() From: JoonSoo Kim To: Peter Zijlstra Cc: Joonsoo Kim , Ingo Molnar , Srivatsa Vaddagiri , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1567 Lines: 37 2013/3/20 Peter Zijlstra : > On Wed, 2013-03-20 at 16:43 +0900, Joonsoo Kim wrote: >> On Tue, Mar 19, 2013 at 04:05:46PM +0100, Peter Zijlstra wrote: >> > On Thu, 2013-02-14 at 14:48 +0900, Joonsoo Kim wrote: >> > > Commit 88b8dac0 makes load_balance() consider other cpus in its group. >> > > But, in that, there is no code for preventing to re-select dst-cpu. >> > > So, same dst-cpu can be selected over and over. >> > > >> > > This patch add functionality to load_balance() in order to exclude >> > > cpu which is selected once. >> > >> > Oh man.. seriously? Did you see this happen? Also, can't we simply >> > remove it from lb->cpus? >> >> I didn't see it, I do just logical thinking. :) >> lb->cpus is for source cpus and dst-cpu is for dest cpus. So, it doesn't >> works to remove it from lb->cpus. > > How about we interpret ->cpus as the total mask to balance; so both > source and destination. That way clearing a cpu means we won't take nor > put tasks on it. In my quick thought, it may be possible. I will try to do it. Thanks. > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/