Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933021Ab3CTP0O (ORCPT ); Wed, 20 Mar 2013 11:26:14 -0400 Received: from mail-ie0-f173.google.com ([209.85.223.173]:39460 "EHLO mail-ie0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752024Ab3CTP0L (ORCPT ); Wed, 20 Mar 2013 11:26:11 -0400 MIME-Version: 1.0 In-Reply-To: <20130320150554.GX3042@htj.dyndns.org> References: <1363737629-16745-1-git-send-email-tj@kernel.org> <1363737629-16745-10-git-send-email-tj@kernel.org> <20130320150554.GX3042@htj.dyndns.org> Date: Wed, 20 Mar 2013 23:26:10 +0800 Message-ID: Subject: Re: [PATCH 09/10] workqueue: implement NUMA affinity for unbound workqueues From: Lai Jiangshan To: Tejun Heo Cc: laijs@cn.fujitsu.com, axboe@kernel.dk, jack@suse.cz, fengguang.wu@intel.com, jmoyer@redhat.com, zab@redhat.com, linux-kernel@vger.kernel.org, herbert@gondor.hengli.com.au, davem@davemloft.net, linux-crypto@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 893 Lines: 31 On Wed, Mar 20, 2013 at 11:05 PM, Tejun Heo wrote: > On Wed, Mar 20, 2013 at 11:03:53PM +0800, Lai Jiangshan wrote: >> > +enomem: >> > + free_workqueue_attrs(tmp_attrs); >> > + if (pwq_tbl) { >> > + for_each_node(node) >> > + kfree(pwq_tbl[node]); >> >> It will free the dfl_pwq multi times. > > Oops, you're right. We need to do > > > for_eahc_node(node) > if (pwq_tbl[node] != dfl_pwq) > kfree(pwq_tbl[node]); > kfree(dfl_pwq); I also missed. we still need to put_unbound_pool() before free(pwq) > > Thanks! > > -- > tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/