Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757425Ab3CTPof (ORCPT ); Wed, 20 Mar 2013 11:44:35 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:54085 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751975Ab3CTPod (ORCPT ); Wed, 20 Mar 2013 11:44:33 -0400 Message-ID: <5149D95D.2030505@ti.com> Date: Wed, 20 Mar 2013 10:44:29 -0500 From: Jon Hunter User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: Tomi Valkeinen CC: Alexandru Gheorghiu , Florian Tobias Schandinat , , Subject: Re: [PATCH] drivers: video: omap2: dss: Use PTR_RET function References: <1363680194-10404-1-git-send-email-gheorghiuandru@gmail.com> <5149A3D0.2010902@ti.com> In-Reply-To: <5149A3D0.2010902@ti.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.157.144.139] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1519 Lines: 43 On 03/20/2013 06:56 AM, Tomi Valkeinen wrote: > On 2013-03-19 10:03, Alexandru Gheorghiu wrote: >> Use PTR_RET function instead of IS_ERR and PTR_ERR. >> Patch found using coccinelle. >> >> Signed-off-by: Alexandru Gheorghiu >> --- >> drivers/video/omap2/dss/core.c | 5 +---- >> 1 file changed, 1 insertion(+), 4 deletions(-) >> >> diff --git a/drivers/video/omap2/dss/core.c b/drivers/video/omap2/dss/core.c >> index f8779d4..60cc6fe 100644 >> --- a/drivers/video/omap2/dss/core.c >> +++ b/drivers/video/omap2/dss/core.c >> @@ -181,10 +181,7 @@ int dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)) >> d = debugfs_create_file(name, S_IRUGO, dss_debugfs_dir, >> write, &dss_debug_fops); >> >> - if (IS_ERR(d)) >> - return PTR_ERR(d); >> - >> - return 0; >> + return PTR_RET(d); >> } >> #else /* CONFIG_OMAP2_DSS_DEBUGFS */ >> static inline int dss_initialize_debugfs(void) >> > > Thanks. I'll apply to omapdss tree. Is this correct? If debugfs_create_file() returns a valid pointer, then now dss_debugfs_create_file() will return a non-zero value on success. I don't think this is what you want. A similar case came up recently here [1]. Jon [1] http://comments.gmane.org/gmane.linux.kernel/1455141 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/