Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933039Ab3CTQJI (ORCPT ); Wed, 20 Mar 2013 12:09:08 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:42088 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755227Ab3CTQJG (ORCPT ); Wed, 20 Mar 2013 12:09:06 -0400 Date: Wed, 20 Mar 2013 16:08:53 +0000 From: Al Viro To: Shankar Brahadeeswaran Cc: Greg Kroah-Hartman , Dan Carpenter , Andrew Morton , Konstantin Khlebnikov , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Hugh Dickins Subject: Re: [BUG] staging: android: ashmem: Deadlock during ashmem_mmap and ashmem_read Message-ID: <20130320160853.GP21522@ZenIV.linux.org.uk> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 850 Lines: 20 On Wed, Mar 20, 2013 at 09:08:03PM +0530, Shankar Brahadeeswaran wrote: > Hi Greg, Dan, > > Few days back I posted a patch to fix a dead lock issue in the ashmem > driver that got merged in staging-next branch > https://lkml.org/lkml/2013/2/20/429 > > I'm seeing that there exists another path in the ashmem driver that > could lead to the similar issue. But this time I'm unable to think of > a way to fix the problem. > > - The objects involved in the deadlock are same, mmap->sem and ashmem_mutex Umm... why does it need to hold that mutex past having checked that asma->file is non-NULL, anyway? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/