Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755153Ab3CTR3G (ORCPT ); Wed, 20 Mar 2013 13:29:06 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:59113 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752190Ab3CTR3E (ORCPT ); Wed, 20 Mar 2013 13:29:04 -0400 Date: Wed, 20 Mar 2013 13:29:01 -0400 (EDT) Message-Id: <20130320.132901.1638904507644521607.davem@davemloft.net> To: fweisbec@gmail.com Cc: cmetcalf@tilera.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, gilad@benyossef.com, sasha.levin@oracle.com, akpm@linux-foundation.org, paulmck@linux.vnet.ibm.com, yoshfuji@linux-ipv6.org Subject: Re: [PATCH] dynticks: avoid flow_cache_flush() interrupting every core From: David Miller In-Reply-To: References: <201303192143.r2JLhZIX020469@farm-0021.internal.tilera.com> <20130320.121704.1797978839297064162.davem@davemloft.net> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (shards.monkeyblade.net [0.0.0.0]); Wed, 20 Mar 2013 10:29:08 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1516 Lines: 35 From: Frederic Weisbecker Date: Wed, 20 Mar 2013 17:37:04 +0100 > 2013/3/20 David Miller : >> From: Chris Metcalf >> Date: Tue, 19 Mar 2013 17:35:58 -0400 >> >>> Previously, if you did an "ifconfig down" or similar on one core, and >>> the kernel had CONFIG_XFRM enabled, every core would be interrupted to >>> check its percpu flow list for items that could be garbage collected. >>> >>> With this change, we generate a mask of cores that actually have any >>> percpu items, and only interrupt those cores. When we are trying to >>> isolate a set of cpus from interrupts, this is important to do. >>> >>> Signed-off-by: Chris Metcalf >>> --- >>> This change stands alone so could be taken into the net tree if >>> desired, but it is most useful in the context of Frederic Weisbecker's >>> linux-dynticks work. So it could be taken up through either tree, >>> but it certainly needs sign-off from someone familiar with net/core/flow.c. >> >> I'm find with this going into the dynticks changes: >> >> Acked-by: David S. Miller > > At it looks pretty self-contained, can that perhaps go through the > networking tree? Fair enough, applied to net-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/