Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757857Ab3CTTXm (ORCPT ); Wed, 20 Mar 2013 15:23:42 -0400 Received: from cantor2.suse.de ([195.135.220.15]:54236 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751120Ab3CTTXk (ORCPT ); Wed, 20 Mar 2013 15:23:40 -0400 Date: Wed, 20 Mar 2013 20:23:39 +0100 Message-ID: From: Takashi Iwai To: Matthew Garrett Cc: Bjorn Helgaas , Oliver Neukum , Michal Marek , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pciehp: Add pciehp_surprise module option In-Reply-To: <20130320191250.GA11262@srcf.ucam.org> References: <20130320175234.GA8948@srcf.ucam.org> <20130320191250.GA11262@srcf.ucam.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1093 Lines: 32 At Wed, 20 Mar 2013 19:12:50 +0000, Matthew Garrett wrote: > > On Wed, Mar 20, 2013 at 08:11:15PM +0100, Takashi Iwai wrote: > > At Wed, 20 Mar 2013 17:52:34 +0000, > > Matthew Garrett wrote: > > > Well that just sounds like a bug. What's the downside to just ignoring > > > that capability bit? > > > > I'm afraid that it's too radical to enable always. > > Why? Because I'm conservative :) Well, dunno. It's just my feeling without deep thought. > > Or, what about to check this bit only for disable path? > > What happens if you unplug the device on one of the affected machines? It continues working. I mean, the PCI device is still there after unplug, but the Realtek driver unmounts it smoothly. Re-plugging also works, too. So, the handling via pciehp is needed only for the very first time to register the PCI device. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/