Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757531Ab3CTT0u (ORCPT <rfc822;w@1wt.eu>);
	Wed, 20 Mar 2013 15:26:50 -0400
Received: from cavan.codon.org.uk ([93.93.128.6]:42293 "EHLO
	cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750763Ab3CTT0s (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 20 Mar 2013 15:26:48 -0400
Date: Wed, 20 Mar 2013 19:26:04 +0000
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>, Oliver Neukum <oneukum@suse.de>,
        Michal Marek <mmarek@suse.cz>, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pciehp: Add pciehp_surprise module option
Message-ID: <20130320192604.GA11660@srcf.ucam.org>
References: <s5h38vqjhk6.wl%tiwai@suse.de>
 <20130320175234.GA8948@srcf.ucam.org>
 <s5hppytq430.wl%tiwai@suse.de>
 <20130320191250.GA11262@srcf.ucam.org>
 <s5hmwtxq3ic.wl%tiwai@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <s5hmwtxq3ic.wl%tiwai@suse.de>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: mjg59@cavan.codon.org.uk
X-SA-Exim-Scanned: No (on cavan.codon.org.uk); SAEximRunCond expanded to false
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1317
Lines: 33

On Wed, Mar 20, 2013 at 08:23:39PM +0100, Takashi Iwai wrote:
> At Wed, 20 Mar 2013 19:12:50 +0000,
> Matthew Garrett wrote:
> > On Wed, Mar 20, 2013 at 08:11:15PM +0100, Takashi Iwai wrote:
> > > I'm afraid that it's too radical to enable always.
> > 
> > Why?
> 
> Because I'm conservative :)
> Well, dunno.  It's just my feeling without deep thought.

Adding a parameter means it's broken until people discover that they 
need to pass a parameter to make it work, and many people will just be 
stuck with it not working. It really should be the last resort.

> > > Or, what about to check this bit only for disable path?
> > 
> > What happens if you unplug the device on one of the affected machines?
> 
> It continues working.  I mean, the PCI device is still there after
> unplug, but the Realtek driver unmounts it smoothly.  Re-plugging also
> works, too.  So, the handling via pciehp is needed only for the very
> first time to register the PCI device.

But if I plug in a different device, things will be broken, right?

-- 
Matthew Garrett | mjg59@srcf.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/