Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754891Ab3CUBk4 (ORCPT ); Wed, 20 Mar 2013 21:40:56 -0400 Received: from mail-oa0-f43.google.com ([209.85.219.43]:44191 "EHLO mail-oa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754651Ab3CUBkx convert rfc822-to-8bit (ORCPT ); Wed, 20 Mar 2013 21:40:53 -0400 MIME-Version: 1.0 In-Reply-To: <20130320085241.GA10570@zurbaran> References: <1361830121-32284-1-git-send-email-sjg@chromium.org> <20130320005652.GC26903@zurbaran> <20130320011211.GA5905@zurbaran> <20130320081456.GA5939@zurbaran> <20130320085241.GA10570@zurbaran> Date: Wed, 20 Mar 2013 18:40:53 -0700 X-Google-Sender-Auth: QqlTw-iv_zrxqHr-7ix3UocjY_o Message-ID: Subject: Re: [PATCH v6 0/6] Add ChromeOS Embedded Controller support From: Simon Glass To: Samuel Ortiz Cc: LKML , Rob Landley , Felipe Balbi , Grant Likely , Wolfram Sang , Luigi Semenzato , Rob Herring , Che-Liang Chiou , Jonathan Kliegman , "linux-input@vger.kernel.org" , Sourav Poddar , Devicetree Discuss , Alban Bedel , Roland Stigge , Vincent Palatin , Javier Martinez Canillas , Mark Brown , "linux-doc@vger.kernel.org" , Dmitry Torokhov , Tony Lindgren , Bill Pemberton Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1995 Lines: 51 Hi Samuel, On Wed, Mar 20, 2013 at 1:52 AM, Samuel Ortiz wrote: > Hi Simon, > > On Wed, Mar 20, 2013 at 09:14:56AM +0100, Samuel Ortiz wrote: >> On Tue, Mar 19, 2013 at 07:01:42PM -0700, Simon Glass wrote: >> > Hi Samuel, >> > >> > On Tue, Mar 19, 2013 at 6:12 PM, Samuel Ortiz wrote: >> > > On Wed, Mar 20, 2013 at 01:56:52AM +0100, Samuel Ortiz wrote: >> > >> Hi Simon, >> > >> >> > >> On Mon, Feb 25, 2013 at 02:08:35PM -0800, Simon Glass wrote: >> > >> > The ChromeOS Embedded Controller (EC) is an Open Source EC implementation >> > >> > used on ARM and Intel Chromebooks. Current implementations use a Cortex-M3 >> > >> > connected on a bus (such as I2C, SPI, LPC) to the AP. A separate interrupt >> > >> > line is used to indicate when the EC needs service. >> > >> All 6 patches applied to my mfd-next tree, thanks a lot. >> > > Actually, this one fails to build when CONFIG_OF is not set: >> > > >> > > drivers/mfd/cros_ec_i2c.c:130:2: error: implicit declaration of function >> > > ?of_device_is_available? [-Werror=implicit-function-declaration] >> > > >> > > If the check in cros_ec_probe_i2c() is really needed then you'll need to inline >> > > of_device_is_available() into a NOP in include/linux/of.h. >> > >> > Actually I suppose that call is not really needed. Would you like to >> > remove it, or shall I send a new patch? >> I will remove it. > This is fixed and pushed. I also fixed some warnings and another build failure > for the case when all of your code is modular. Thank you for that. I don't think I quite understood the different build tests that I needed to do. Regards, Simon > > Cheers, > Samuel. > > -- > Intel Open Source Technology Centre > http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/