Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753758Ab3CUEph (ORCPT ); Thu, 21 Mar 2013 00:45:37 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:51335 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751603Ab3CUEpg (ORCPT ); Thu, 21 Mar 2013 00:45:36 -0400 X-SecurityPolicyCheck: OK by SHieldMailChecker v1.7.4 Message-ID: <514A905C.6070204@jp.fujitsu.com> Date: Thu, 21 Mar 2013 13:45:16 +0900 From: Yasuaki Ishimatsu User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 MIME-Version: 1.0 To: Toshi Kani , CC: , , , , Subject: Re: [PATCH 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit References: <514022BF.3080303@jp.fujitsu.com> <1363186213.12845.174.camel@misato.fc.hp.com> <514679BC.5020700@jp.fujitsu.com> <1363705437.11659.5.camel@misato.fc.hp.com> <514A4CCD.6000608@jp.fujitsu.com> <514A8E3C.1050902@jp.fujitsu.com> <514A8EF3.90203@jp.fujitsu.com> In-Reply-To: <514A8EF3.90203@jp.fujitsu.com> Content-Type: multipart/mixed; boundary="------------080702000409010506020806" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4674 Lines: 142 --------------080702000409010506020806 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit The mail's tab become spaces. So I attached origianl patch. Thanks, Yasuaki Ishimatsu 2013/03/21 13:39, Yasuaki Ishimatsu wrote: > acpi_memory_info has enabled bit and failed bit for controlling memory > hotplug. But we don't need to keep both bits. > > The patch removes acpi_memory_info->failed bit. > > Signed-off-by: yasuaki ishimatsu > --- > > v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge. > > --- > drivers/acpi/acpi_memhotplug.c | 13 +------------ > 1 files changed, 1 insertions(+), 12 deletions(-) > > diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c > index ea78988..597cd65 100644 > --- a/drivers/acpi/acpi_memhotplug.c > +++ b/drivers/acpi/acpi_memhotplug.c > @@ -73,7 +73,6 @@ struct acpi_memory_info { > unsigned short caching; /* memory cache attribute */ > unsigned short write_protect; /* memory read/write attribute */ > unsigned int enabled:1; > - unsigned int failed:1; > }; > > struct acpi_memory_device { > @@ -201,10 +200,8 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device) > * returns -EEXIST. If add_memory() returns the other error, it > * means that this memory block is not used by the kernel. > */ > - if (result && result != -EEXIST) { > - info->failed = 1; > + if (result && result != -EEXIST) > continue; > - } > > info->enabled = 1; > > @@ -238,15 +235,7 @@ static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device) > nid = acpi_get_node(mem_device->device->handle); > > list_for_each_entry_safe(info, n, &mem_device->res_list, list) { > - if (info->failed) > - /* The kernel does not use this memory block */ > - continue; > - > if (!info->enabled) > - /* > - * The kernel uses this memory block, but it may be not > - * managed by us. > - */ > return -EBUSY; > > if (nid < 0) > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --------------080702000409010506020806 Content-Type: text/x-patch; name="0002-Remove-acpi_memory_info-failed-bit.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0002-Remove-acpi_memory_info-failed-bit.patch" acpi_memory_info has enabled bit and failed bit for controlling memory hotplug. But we don't need to keep both bits. The patch removes acpi_memory_info->failed bit. Signed-off-by: yasuaki ishimatsu --- v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge. --- drivers/acpi/acpi_memhotplug.c | 13 +------------ 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c index ea78988..597cd65 100644 --- a/drivers/acpi/acpi_memhotplug.c +++ b/drivers/acpi/acpi_memhotplug.c @@ -73,7 +73,6 @@ struct acpi_memory_info { unsigned short caching; /* memory cache attribute */ unsigned short write_protect; /* memory read/write attribute */ unsigned int enabled:1; - unsigned int failed:1; }; struct acpi_memory_device { @@ -201,10 +200,8 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device) * returns -EEXIST. If add_memory() returns the other error, it * means that this memory block is not used by the kernel. */ - if (result && result != -EEXIST) { - info->failed = 1; + if (result && result != -EEXIST) continue; - } info->enabled = 1; @@ -238,15 +235,7 @@ static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device) nid = acpi_get_node(mem_device->device->handle); list_for_each_entry_safe(info, n, &mem_device->res_list, list) { - if (info->failed) - /* The kernel does not use this memory block */ - continue; - if (!info->enabled) - /* - * The kernel uses this memory block, but it may be not - * managed by us. - */ return -EBUSY; if (nid < 0) -- 1.7.1 --------------080702000409010506020806-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/