Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758330Ab3CUNyY (ORCPT ); Thu, 21 Mar 2013 09:54:24 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:59117 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757433Ab3CUNyX (ORCPT ); Thu, 21 Mar 2013 09:54:23 -0400 Message-ID: <514B10FE.1000805@ti.com> Date: Thu, 21 Mar 2013 15:54:06 +0200 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Rajendra Nayak CC: , , , , , , , , Subject: Re: [RFC][PATCH 1/2] ARM: OMAP4: clock: Add device tree support for AUXCLKs References: <1363703220-4777-1-git-send-email-rogerq@ti.com> <1363703220-4777-2-git-send-email-rogerq@ti.com> <514B0650.5070406@ti.com> In-Reply-To: <514B0650.5070406@ti.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1808 Lines: 60 On 03/21/2013 03:08 PM, Rajendra Nayak wrote: > [].. > >> diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c >> index 0274ff7..23f2064 100644 >> --- a/arch/arm/mach-omap2/board-generic.c >> +++ b/arch/arm/mach-omap2/board-generic.c >> @@ -158,7 +158,7 @@ DT_MACHINE_START(OMAP4_DT, "Generic OMAP4 (Flattened Device Tree)") >> .init_irq = omap_gic_of_init, >> .init_machine = omap_generic_init, >> .init_late = omap4430_init_late, >> - .init_time = omap4_local_timer_init, >> + .init_time = omap4_init_time, >> .dt_compat = omap4_boards_compat, >> .restart = omap44xx_restart, >> MACHINE_END > > [].. >> +#ifdef CONFIG_OF >> +int __init omap4_clk_init_dt(void) >> +{ >> + struct device_node *np; >> + >> + np = of_find_compatible_node(NULL, NULL, "ti,omap4-scrm"); >> + if (np) { >> + scrm_data.clks = scrm_clks; >> + scrm_data.clk_num = ARRAY_SIZE(scrm_clks); >> + of_clk_add_provider(np, of_clk_src_onecell_get, &scrm_data); >> + } >> + >> + return 0; >> +} > > [].. >> + >> +void __init omap4_init_time(void) >> +{ >> + omap4_clk_init_dt(); >> + omap4_local_timer_init(); >> +} > > I guess you did all this because of_clk_add_provider() needs > slab to be initialized. With the below patch[1], now clk inits > happen within .init_timer already, so none of this would > be needed. > > [1] http://www.spinics.net/lists/arm-kernel/msg231288.html > Right. I can then call omap4_clk_init_dt() from within omap4xxx_clk_init(). Any comments about the main subject? Does the approach look fine? cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/