Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933603Ab3CUOlY (ORCPT ); Thu, 21 Mar 2013 10:41:24 -0400 Received: from casper.infradead.org ([85.118.1.10]:50660 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932834Ab3CUOlW (ORCPT ); Thu, 21 Mar 2013 10:41:22 -0400 Date: Thu, 21 Mar 2013 14:41:20 +0000 From: Thomas Graf To: Andrew Vagin Cc: Andrey Vagin , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Pavel Emelyanov , Pablo Neira Ayuso , "Eric W. Biederman" , Gao feng Subject: Re: [PATCH 2/2] netlink: Diag core and basic socket info dumping Message-ID: <20130321144120.GE9046@casper.infradead.org> References: <1363857669-19990-1-git-send-email-avagin@openvz.org> <1363857669-19990-3-git-send-email-avagin@openvz.org> <20130321125230.GB9046@casper.infradead.org> <20130321143119.GA14763@paralelels.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130321143119.GA14763@paralelels.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 840 Lines: 21 On 03/21/13 at 06:31pm, Andrew Vagin wrote: > The code in ss looks like you described: > struct rtattr *tb[UNIX_DIAG_MAX+1]; > ... > parse_rtattr(tb, UNIX_DIAG_MAX, (struct rtattr*)(r+1), > nlh->nlmsg_len - NLMSG_LENGTH(sizeof(*r))); > > > struct rtattr *tb[NETLINK_DIAG_MAX+1]; > ... > parse_rtattr(tb, NETLINK_DIAG_MAX, (struct rtattr*)(r+1), > nlh->nlmsg_len - NLMSG_LENGTH(sizeof(*r))) > > I think I should only update headers... Or I don't understand something. Right, fixing the headers will resolve the issue. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/