Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932573Ab3CUPOl (ORCPT ); Thu, 21 Mar 2013 11:14:41 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:43115 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752514Ab3CUPOk (ORCPT ); Thu, 21 Mar 2013 11:14:40 -0400 Date: Thu, 21 Mar 2013 11:14:37 -0400 (EDT) Message-Id: <20130321.111437.2012746070698745131.davem@davemloft.net> To: tgraf@suug.ch Cc: avagin@openvz.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xemul@parallels.com, edumazet@google.com, paulmck@linux.vnet.ibm.com, dhowells@redhat.com Subject: Re: [PATCH] net: fix *_DIAG_MAX constants From: David Miller In-Reply-To: <20130321144218.GF9046@casper.infradead.org> References: <1363875500-14574-1-git-send-email-avagin@openvz.org> <20130321144218.GF9046@casper.infradead.org> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (shards.monkeyblade.net [0.0.0.0]); Thu, 21 Mar 2013 08:14:43 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1405 Lines: 40 From: Thomas Graf Date: Thu, 21 Mar 2013 14:42:18 +0000 > On 03/21/13 at 06:18pm, Andrey Vagin wrote: >> Follow the common pattern and define *_DIAG_MAX like: >> >> [...] >> __XXX_DIAG_MAX, >> }; >> >> Because everyone is used to do: >> >> struct nlattr *attrs[XXX_DIAG_MAX+1]; >> >> nla_parse([...], XXX_DIAG_MAX, [...] >> >> Reported-by: Thomas Graf >> Cc: "David S. Miller" >> Cc: Pavel Emelyanov >> Cc: Eric Dumazet >> Cc: "Paul E. McKenney" >> Cc: David Howells >> Signed-off-by: Andrey Vagin > > Acked-by: Thomas Graf So you're ACK'ing a patch that makes changes to files that don't even exist in the repository? Andrey, post a clean patch against 'net' that fixes these constants for existing code, don't just assume that your original patch set is applied and post changes relative to that. That's not how we work. After the bug fix for the existing cases goes in, you have to repost your original patch set on top of that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/