Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934226Ab3CUQrm (ORCPT ); Thu, 21 Mar 2013 12:47:42 -0400 Received: from cantor2.suse.de ([195.135.220.15]:41880 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933751Ab3CUQrk (ORCPT ); Thu, 21 Mar 2013 12:47:40 -0400 Date: Thu, 21 Mar 2013 16:47:37 +0000 From: Mel Gorman To: Johannes Weiner Cc: Linux-MM , Jiri Slaby , Valdis Kletnieks , Rik van Riel , Zlatko Calusic , dormando , Satoru Moriya , Michal Hocko , LKML Subject: Re: [PATCH 01/10] mm: vmscan: Limit the number of pages kswapd reclaims at each priority Message-ID: <20130321164737.GL1878@suse.de> References: <1363525456-10448-1-git-send-email-mgorman@suse.de> <1363525456-10448-2-git-send-email-mgorman@suse.de> <20130321155705.GA27848@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20130321155705.GA27848@cmpxchg.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2259 Lines: 50 On Thu, Mar 21, 2013 at 11:57:05AM -0400, Johannes Weiner wrote: > On Sun, Mar 17, 2013 at 01:04:07PM +0000, Mel Gorman wrote: > > The number of pages kswapd can reclaim is bound by the number of pages it > > scans which is related to the size of the zone and the scanning priority. In > > many cases the priority remains low because it's reset every SWAP_CLUSTER_MAX > > reclaimed pages but in the event kswapd scans a large number of pages it > > cannot reclaim, it will raise the priority and potentially discard a large > > percentage of the zone as sc->nr_to_reclaim is ULONG_MAX. The user-visible > > effect is a reclaim "spike" where a large percentage of memory is suddenly > > freed. It would be bad enough if this was just unused memory but because > > of how anon/file pages are balanced it is possible that applications get > > pushed to swap unnecessarily. > > > > This patch limits the number of pages kswapd will reclaim to the high > > watermark. Reclaim will will overshoot due to it not being a hard limit as > > will -> still? > > > shrink_lruvec() will ignore the sc.nr_to_reclaim at DEF_PRIORITY but it > > prevents kswapd reclaiming the world at higher priorities. The number of > > pages it reclaims is not adjusted for high-order allocations as kswapd will > > reclaim excessively if it is to balance zones for high-order allocations. > > I don't really understand this last sentence. Is the excessive > reclaim a result of the patch, a description of what's happening > now...? > It's a very basic description of what happens now and with the patch applied. Until patch 5 is applied, kswapd can still reclaim the world if it reaches priority 0. > > Signed-off-by: Mel Gorman > > Nice, thank you. Using the high watermark for larger zones is more > reasonable than my hack that just always went with SWAP_CLUSTER_MAX, > what with inter-zone LRU cycle time balancing and all. > > Acked-by: Johannes Weiner Thanks. -- Mel Gorman SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/