Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751883Ab3CUR4h (ORCPT ); Thu, 21 Mar 2013 13:56:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51415 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751140Ab3CUR4f (ORCPT ); Thu, 21 Mar 2013 13:56:35 -0400 Message-ID: <514B4925.2010909@redhat.com> Date: Thu, 21 Mar 2013 13:53:41 -0400 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Mel Gorman CC: Andi Kleen , Linux-MM , Jiri Slaby , Valdis Kletnieks , Zlatko Calusic , Johannes Weiner , dormando , Satoru Moriya , Michal Hocko , LKML Subject: Re: [PATCH 06/10] mm: vmscan: Have kswapd writeback pages based on dirty pages encountered, not priority References: <1363525456-10448-1-git-send-email-mgorman@suse.de> <1363525456-10448-7-git-send-email-mgorman@suse.de> <20130317151155.GC2026@suse.de> In-Reply-To: <20130317151155.GC2026@suse.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1386 Lines: 42 On 03/17/2013 11:11 AM, Mel Gorman wrote: > On Sun, Mar 17, 2013 at 07:42:39AM -0700, Andi Kleen wrote: >> Mel Gorman writes: >> >>> @@ -495,6 +495,9 @@ typedef enum { >>> ZONE_CONGESTED, /* zone has many dirty pages backed by >>> * a congested BDI >>> */ >>> + ZONE_DIRTY, /* reclaim scanning has recently found >>> + * many dirty file pages >>> + */ >> >> Needs a better name. ZONE_DIRTY_CONGESTED ? >> > > That might be confusing. The underlying BDI is not necessarily > congested. I accept your point though and will try thinking of a better > name. ZONE_LOTS_DIRTY ? >>> + * currently being written then flag that kswapd should start >>> + * writing back pages. >>> + */ >>> + if (global_reclaim(sc) && nr_dirty && >>> + nr_dirty >= (nr_taken >> (DEF_PRIORITY - sc->priority))) >>> + zone_set_flag(zone, ZONE_DIRTY); >>> + >>> trace_mm_vmscan_lru_shrink_inactive(zone->zone_pgdat->node_id, >> >> I suppose you want to trace the dirty case here too. >> > > I guess it wouldn't hurt to have a new tracepoint for when the flag gets > set. A vmstat might be helpful as well. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/