Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752025Ab3CUR6s (ORCPT ); Thu, 21 Mar 2013 13:58:48 -0400 Received: from www.sr71.net ([198.145.64.142]:51769 "EHLO blackbird.sr71.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751697Ab3CUR6q (ORCPT ); Thu, 21 Mar 2013 13:58:46 -0400 Message-ID: <514B4A9F.5090004@sr71.net> Date: Thu, 21 Mar 2013 10:59:59 -0700 From: Dave Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: "Kirill A. Shutemov" CC: Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2, RFC 12/30] thp, mm: add event counters for huge page alloc on write to a file References: <1363283435-7666-1-git-send-email-kirill.shutemov@linux.intel.com> <1363283435-7666-13-git-send-email-kirill.shutemov@linux.intel.com> In-Reply-To: <1363283435-7666-13-git-send-email-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 989 Lines: 23 On 03/14/2013 10:50 AM, Kirill A. Shutemov wrote: > --- a/include/linux/vm_event_item.h > +++ b/include/linux/vm_event_item.h > @@ -71,6 +71,8 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, > THP_FAULT_FALLBACK, > THP_COLLAPSE_ALLOC, > THP_COLLAPSE_ALLOC_FAILED, > + THP_WRITE_ALLOC, > + THP_WRITE_FAILED, > THP_SPLIT, > THP_ZERO_PAGE_ALLOC, > THP_ZERO_PAGE_ALLOC_FAILED, I think these names are a bit terse. It's certainly not _writes_ that are failing and "THP_WRITE_FAILED" makes it sound that way. Also, why do we need to differentiate these from the existing anon-hugepage vm stats? The alloc_pages() call seems to be doing the exact same thing in the end. Is one more likely to succeed than the other? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/