Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753340Ab3CUVJT (ORCPT ); Thu, 21 Mar 2013 17:09:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20559 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751525Ab3CUVJR (ORCPT ); Thu, 21 Mar 2013 17:09:17 -0400 Date: Thu, 21 Mar 2013 18:08:57 -0300 From: Mauro Carvalho Chehab To: Randy Dunlap Cc: Geert Uytterhoeven , Linux Kernel Development , Janne Grunau , linux-media , Hans Verkuil Subject: Re: [PATCH] media: fix hdpvr build warning Message-ID: <20130321180857.5de49d16@redhat.com> In-Reply-To: <514B5814.4020309@infradead.org> References: <513F769D.6040306@infradead.org> <20130321154509.46ad14e3@redhat.com> <514B5814.4020309@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2161 Lines: 79 Em Thu, 21 Mar 2013 11:57:24 -0700 Randy Dunlap escreveu: > On 03/21/13 11:45, Mauro Carvalho Chehab wrote: > > Em Tue, 12 Mar 2013 11:40:29 -0700 > > Randy Dunlap escreveu: > > > >> From: Randy Dunlap > >> > >> Fix build warning in hdpvr: > >> > >> drivers/media/usb/hdpvr/hdpvr-video.c: warning: "CONFIG_I2C_MODULE" is not defined [-Wundef] > >> > >> Signed-off-by: Randy Dunlap > >> Reported-by: Geert Uytterhoeven > >> Cc: Janne Grunau > > > > From time to time, people used to write those checks wrong. So, > > we're now using a macro to avoid those problems (IS_ENABLED). The better > > is to also use it here. > > > > From time to time, people omit including header files that should be > included. Heh ;) > Please add > > #include > > to this patch. Ok, I'll do it. > > Thank you. > > > > - > > > > [PATCH] Use the proper check for I2C support > > > > As reported by Geert Uytterhoeven : > > > > drivers/media/usb/hdpvr/hdpvr-video.c: warning: "CONFIG_I2C_MODULE" is not defined [-Wundef] > > > > Signed-off-by: Mauro Carvalho Chehab > > > > diff --git a/drivers/media/usb/hdpvr/hdpvr-video.c b/drivers/media/usb/hdpvr/hdpvr-video.c > > index da6b779..554d2eb 100644 > > --- a/drivers/media/usb/hdpvr/hdpvr-video.c > > +++ b/drivers/media/usb/hdpvr/hdpvr-video.c > > @@ -1238,7 +1238,7 @@ static void hdpvr_device_release(struct video_device *vdev) > > v4l2_device_unregister(&dev->v4l2_dev); > > > > /* deregister I2C adapter */ > > -#if defined(CONFIG_I2C) || (CONFIG_I2C_MODULE) > > +#if IS_ENABLED(CONFIG_I2C) > > mutex_lock(&dev->i2c_mutex); > > i2c_del_adapter(&dev->i2c_adapter); > > mutex_unlock(&dev->i2c_mutex); > > > > Cheers, > > Mauro > > > > -- Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/