Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754085Ab3CUXHw (ORCPT ); Thu, 21 Mar 2013 19:07:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20770 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754037Ab3CUXHu (ORCPT ); Thu, 21 Mar 2013 19:07:50 -0400 Date: Thu, 21 Mar 2013 19:07:46 -0400 From: Dave Jones To: Linus Torvalds Cc: Al Viro , Linux Kernel Subject: Re: VFS deadlock ? Message-ID: <20130321230746.GA3116@redhat.com> Mail-Followup-To: Dave Jones , Linus Torvalds , Al Viro , Linux Kernel References: <20130321192935.GY21522@ZenIV.linux.org.uk> <20130321202635.GA16406@redhat.com> <20130321203639.GC16406@redhat.com> <20130321204704.GZ21522@ZenIV.linux.org.uk> <20130321210255.GD16406@redhat.com> <20130321221256.GA30620@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1485 Lines: 36 On Thu, Mar 21, 2013 at 03:53:13PM -0700, Linus Torvalds wrote: > On Thu, Mar 21, 2013 at 3:12 PM, Dave Jones wrote: > > > > it's not just irda fwiw.. > > > > p1=rpc p2=rpc p1parent=net p2parent=net > > Ok, good. The only rpc/irda that has something in common is > /proc/net/, and they both use proc_mkdir() to create the directory: > > proc_irda = proc_mkdir("irda", init_net.proc_net); > ... > sn->proc_net_rpc = proc_mkdir("rpc", net->proc_net); > > so it's almost certainly that case. What I do *not* see is how we got > two different dentries for the same name in /proc. But if that > happens, then yes, they will have aliased inodes (because > proc_get_inode() will look them up by "sb,de->low_ino". > > Al, any ideas? There shouldn't be some lookup race, because that's > done under the parent inode lock. And multiple mount-points will have > different superblocks, so proc_get_inode() will give them separate > inodes. And bind mounts should have all the same dentry tree. So what > the heck am I missing? Hmm, these also seem to have appeared around about the time I reenabled all the namespace options after Eric fixed that last proc bug. could that be related ? Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/