From: Jingoo Han <jg1.han@samsung.com>
To: "'David Rientjes'" <rientjes@google.com>,
        "'Herbert Xu'" <herbert@gondor.hengli.com.au>
Cc: "'Andrew Morton'" <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, "'Matt Mackall'" <mpm@selenic.com>
References: <003a01ce1ee4$ed8842b0$c898c810$%han@samsung.com>
 <20130321095430.GC26931@gondor.apana.org.au>
 <alpine.DEB.2.02.1303211214230.5662@chino.kir.corp.google.com>
In-reply-to: <alpine.DEB.2.02.1303211214230.5662@chino.kir.corp.google.com>
Subject: Re: [PATCH] hwrng: exynos - add CONFIG_PM_SLEEP to suspend/resume
 functions
Date: Fri, 22 Mar 2013 08:18:54 +0900
Message-id: <008301ce268a$74fb9470$5ef2bd50$%han@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
Thread-index: Ac4maLCAnoPLbPq5SP2LUUT9cu6i7wAITkLA
Content-language: ko
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1366
Lines: 41

On Friday, March 22, 2013 4:17 AM, David Rientjes wrote:
> 
> On Thu, 21 Mar 2013, Herbert Xu wrote:
> 
> > > This patch adds CONFIG_PM_SLEEP to suspend/resume functions to fix
> > > the following build warning when CONFIG_PM_SLEEP is not selected.
> > >
> > > drivers/char/hw_random/exynos-rng.c:147:12: warning: 'exynos_rng_runtime_suspend' defined but not
> used [-Wunused-function]
> > > drivers/char/hw_random/exynos-rng.c:157:12: warning: 'exynos_rng_runtime_resume' defined but not
> used [-Wunused-function]
> > >
> > > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> >
> > Patch applied.  Thanks.
> 
> Nack, it causes build errors when CONFIG_PM_SLEEP is disabled:
> 
> drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_suspend' undeclared here (not in a
> function)
> drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_resume' undeclared here (not in a
> function)

OK, I see.

UNIVERSAL_DEV_PM_OPS is related to both CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME.
Thus, CONFIG_PM_RUNTIME is also necessary.

I will send an additional patch, soon.

Best regards,
Jingoo Han


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/