Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752420Ab3CUXnk (ORCPT ); Thu, 21 Mar 2013 19:43:40 -0400 Received: from hydra.sisk.pl ([212.160.235.94]:59487 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751484Ab3CUXni (ORCPT ); Thu, 21 Mar 2013 19:43:38 -0400 From: "Rafael J. Wysocki" To: Viresh Kumar , robin.randhawa@arm.com Cc: Francesco Lavra , Steve.Bannister@arm.com, linux@arm.linux.org.uk, linux-pm@vger.kernel.org, Sudeep KarkadaNagesha , devicetree-discuss@lists.ozlabs.org, Liviu.Dudau@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mark.hambleton@broadcom.com, linaro-kernel@lists.linaro.org, charles.garcia-tobin@arm.com Subject: Re: [PATCH V2] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue Date: Fri, 22 Mar 2013 00:50:56 +0100 Message-ID: <3782512.fC3ZOYy3MV@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.9.0-rc3+; KDE/4.9.5; x86_64; ; ) In-Reply-To: References: <6cba8f153cfd4b0d3075a34a6dfe287bdec2eb06.1362676407.git.viresh.kumar@linaro.org> <513CAD9B.908@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1886 Lines: 47 On Monday, March 11, 2013 08:57:49 AM Viresh Kumar wrote: > On 10 March 2013 23:58, Francesco Lavra wrote: > > On 03/07/2013 06:14 PM, Viresh Kumar wrote: > >> +void bL_cpufreq_unregister(struct cpufreq_arm_bL_ops *ops) > >> +{ > >> + if (arm_bL_ops != ops) { > >> + pr_info("%s: Registered with: %s, can't unregister, exiting\n", > >> + __func__, arm_bL_ops->name); > >> + } > > > > The code is not doing what the info message says. > > Yes, following is the improvement: Please post a complete update patch if you want me to take it. I'd also would like it to be ACKed by someone involved in the big-LITTLE work on the arch side. Thanks, Rafael > diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c > index 8b8b07e..9d449cf 100644 > --- a/drivers/cpufreq/arm_big_little.c > +++ b/drivers/cpufreq/arm_big_little.c > @@ -264,8 +264,9 @@ EXPORT_SYMBOL_GPL(bL_cpufreq_register); > void bL_cpufreq_unregister(struct cpufreq_arm_bL_ops *ops) > { > if (arm_bL_ops != ops) { > - pr_info("%s: Registered with: %s, can't unregister, exiting\n", > + pr_err("%s: Registered with: %s, can't unregister, exiting\n", > __func__, arm_bL_ops->name); > + return; > } > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/