Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753197Ab3CVATz (ORCPT ); Thu, 21 Mar 2013 20:19:55 -0400 Received: from mail-vc0-f178.google.com ([209.85.220.178]:52817 "EHLO mail-vc0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751926Ab3CVATy (ORCPT ); Thu, 21 Mar 2013 20:19:54 -0400 MIME-Version: 1.0 In-Reply-To: References: <20130321202635.GA16406@redhat.com> <20130321203639.GC16406@redhat.com> <20130321204704.GZ21522@ZenIV.linux.org.uk> <20130321210255.GD16406@redhat.com> <20130321221256.GA30620@redhat.com> <20130321233630.GE21522@ZenIV.linux.org.uk> <20130322000803.GG21522@ZenIV.linux.org.uk> Date: Thu, 21 Mar 2013 17:19:53 -0700 X-Google-Sender-Auth: 4vD7fGzhHKHrgfFVepB3maKsLeU Message-ID: Subject: Re: VFS deadlock ? From: Linus Torvalds To: Al Viro Cc: Dave Jones , Linux Kernel , "Eric W. Biederman" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 952 Lines: 28 Thinking some more.. On Thu, Mar 21, 2013 at 5:15 PM, Linus Torvalds wrote: > > Hmm. But again, that can't actually happen here. We're in /proc. You > can't move the entries around. .. this wasn't a good argument, because we will take the locks before we do that. > Also, we only changed the locking order > for the "inode is identical" case where we take only *one* lock, we > didn't change it for the cases where we take multiple locks (and order > them topologically). .. and this isn't a good argument either, because your argument was that you can get the deadlock by always taking two directories, and never hitting the alias case itself. Hmm. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/