Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754465Ab3CVCvc (ORCPT ); Thu, 21 Mar 2013 22:51:32 -0400 Received: from g4t0017.houston.hp.com ([15.201.24.20]:7861 "EHLO g4t0017.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753997Ab3CVCvb (ORCPT ); Thu, 21 Mar 2013 22:51:31 -0400 Message-ID: <1363920689.31240.70.camel@buesod1.americas.hpqcorp.net> Subject: Re: [PATCH 1/3] rbtree_test: use pr_info for module prefix in messages From: Davidlohr Bueso To: Shuah Khan Cc: Andrew Morton , Michel Lespinasse , LKML Date: Thu, 21 Mar 2013 19:51:29 -0700 In-Reply-To: References: <1363648854.1774.16.camel@buesod1.americas.hpqcorp.net> <1363713282.2781.2.camel@buesod1.americas.hpqcorp.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4 (3.4.4-2.fc17) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1532 Lines: 37 On Tue, 2013-03-19 at 11:54 -0600, Shuah Khan wrote: > On Tue, Mar 19, 2013 at 11:14 AM, Davidlohr Bueso > wrote: > > On Tue, 2013-03-19 at 10:29 -0600, Shuah Khan wrote: > >> On Mon, Mar 18, 2013 at 5:20 PM, Davidlohr Bueso wrote: > >> > This provides nicer message output. Since it seems more appropriate > >> > for the nature of this module, also use KERN_INFO instead of other > >> > levels. > >> > >> Why are you changing the ALERTs to INFO? > > > > Because of the nature of the messages. They don't justify having a > > KERN_ALERT level (requiring immediate attention), and it seems a lot > > more suitable to use INFO instead. > > > > Hmm. I see interval_tree_test using the same alerts. It almost looks > like the start and end of a test are meant to be alerts. I am not > saying it shouldn't be changed, however looking for a stronger reason > than "it seems a lot more suitable to use INFO instead". Are there any > use-cases in which KERN_ALERTs cause problems? > No 'issue' particularly, just common sense. In any case I have no problem reverting the changes back to KERN_ALERT, no big deal. Andrew, Michel, do you have any preferences? I'm mostly interested in patch 3/3, do you have any objections? Thanks, Davidlohr -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/