Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933026Ab3CVLt6 (ORCPT ); Fri, 22 Mar 2013 07:49:58 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:41904 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750736Ab3CVLt5 (ORCPT ); Fri, 22 Mar 2013 07:49:57 -0400 Date: Fri, 22 Mar 2013 11:49:43 +0000 From: Russell King - ARM Linux To: Rob Herring Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, Arnd Bergmann , linus.walleij@linaro.org, haojian.zhuang@linaro.org, pawel.moll@arm.com, john.stultz@linaro.org, tglx@linutronix.de, Rob Herring Subject: Re: [PATCH 03/11] ARM: timer-sp: convert to use CLKSRC_OF init Message-ID: <20130322114943.GC4977@n2100.arm.linux.org.uk> References: <1363820051-24428-1-git-send-email-robherring2@gmail.com> <1363820051-24428-4-git-send-email-robherring2@gmail.com> <20130321193549.GS4977@n2100.arm.linux.org.uk> <514BC265.7080204@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <514BC265.7080204@gmail.com> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 737 Lines: 18 On Thu, Mar 21, 2013 at 09:31:01PM -0500, Rob Herring wrote: > Perhaps re-writing it like this would be more clear: > > if (irq_num == 2){ > __sp804_clockevents_init(base + TIMER_2_BASE, irq, clk1, name); > __sp804_clocksource_and_sched_clock_init(base, name, clk0, 1); > } else { > __sp804_clockevents_init(base, irq, clk0, name); > __sp804_clocksource_and_sched_clock_init(base + TIMER_2_BASE, > name, clk1, 1); > } Yes, that is definitely much clearer than the original patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/