Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933601Ab3CVPFb (ORCPT ); Fri, 22 Mar 2013 11:05:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57905 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932192Ab3CVPFa (ORCPT ); Fri, 22 Mar 2013 11:05:30 -0400 Date: Fri, 22 Mar 2013 16:02:52 +0100 From: Oleg Nesterov To: Anton Arapov Cc: Srikar Dronamraju , LKML , Josh Stone , Frank Eigler , Peter Zijlstra , Ingo Molnar , Ananth N Mavinakayanahalli , adrian.m.negreanu@intel.com, Torsten.Polle@gmx.de Subject: Re: [PATCH 4/7] uretprobes: return probe entry, prepare_uretprobe() Message-ID: <20130322150252.GA17934@redhat.com> References: <1363957745-6657-1-git-send-email-anton@redhat.com> <1363957745-6657-5-git-send-email-anton@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1363957745-6657-5-git-send-email-anton@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1262 Lines: 45 I'll try to read this series later. Just one note... On 03/22, Anton Arapov wrote: > > IOW, we must ensure that uprobe_pre_sstep_notifier() can't return 0. Yes, but I do not see this change? > +static void prepare_uretprobe(struct uprobe *uprobe, struct pt_regs *regs) > +{ > + struct return_instance *ri; > + struct uprobe_task *utask; > + struct xol_area *area; > + unsigned long trampoline_vaddr; > + unsigned long prev_ret_vaddr, ret_vaddr; > + > + area = get_xol_area(); > + if (!area) > + return; > + > + utask = get_utask(); > + if (!utask) > + return; > + > + prev_ret_vaddr = -1; > + if (utask->return_instances) > + prev_ret_vaddr = utask->return_instances->orig_ret_vaddr; > + > + ri = kzalloc(sizeof(struct return_instance), GFP_KERNEL); > + if (!ri) > + return; > + > + ri->dirty = false; > + trampoline_vaddr = get_trampoline_vaddr(area); > + ret_vaddr = arch_uretprobe_hijack_return_addr(trampoline_vaddr, regs); OK, but you need to ensure that this code can be compiled on poweprc. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/