Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161055Ab3CVQlY (ORCPT ); Fri, 22 Mar 2013 12:41:24 -0400 Received: from void.printf.net ([89.145.121.20]:34060 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161013Ab3CVQlW (ORCPT ); Fri, 22 Mar 2013 12:41:22 -0400 From: Chris Ball To: Arnd Bergmann Cc: Kevin Liu , "linux-kernel\@vger.kernel.org List" , Stephen Warren , linux-arm-kernel@lists.infradead.org, Mark Brown , Linus Walleij , Axel Lin , Jingoo Han , Felipe Balbi , Dmitry Torokhov , linux-mmc@vger.kernel.org Subject: Re: FW: Regulator API ignored return values References: <25B60CDC2F704E4E9D88FFD52780CB4C0BDEB0547F@SC-VEXCH1.marvell.com> <201303121403.09315.arnd@arndb.de> <87y5dsheqo.fsf@octavius.laptop.org> Date: Fri, 22 Mar 2013 12:41:00 -0400 In-Reply-To: <87y5dsheqo.fsf@octavius.laptop.org> (Chris Ball's message of "Tue, 12 Mar 2013 10:30:55 -0400") Message-ID: <87d2uro09v.fsf@octavius.laptop.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1137 Lines: 30 Hi, On Tue, Mar 12 2013, Chris Ball wrote: > On Tue, Mar 12 2013, Arnd Bergmann wrote: >>> Need add regulator_put here since regulator_get has succeed? >> >> Hmm, we still don't actually bail out if the error is encountered, so >> the reference count is balanced with the current patch, but I maybe >> a failed regulator_enable() should actually be a fatal error? > > The reason I didn't make it a fatal error is that this is just vqmmc > (responsible for moving from 3.3V to 1.8V for UHS modes), not the > main vmmc regulator. We can just disable those UHS modes from the > capabilities on the host if vqmmc is missing, or failed to enable, > or doesn't support those voltages, and that's what the code does now. I've pushed this patch to mmc-next for 3.10 now, let me know if you disagree. Thanks, - Chris. -- Chris Ball One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/