Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161087Ab3CVRDT (ORCPT ); Fri, 22 Mar 2013 13:03:19 -0400 Received: from void.printf.net ([89.145.121.20]:43792 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161066Ab3CVRDS (ORCPT ); Fri, 22 Mar 2013 13:03:18 -0400 From: Chris Ball To: Sergey Yanovich Cc: Greg Kroah-Hartman , Ulf Hansson , Linus Walleij , Jaehoon Chung , Namjae Jeon , linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org Subject: Re: [PATCH v2] wait while adding MMC host to ensure root mounts References: <1363223183-3772-1-git-send-email-ynvich@gmail.com> <1363224194-7366-1-git-send-email-ynvich@gmail.com> Date: Fri, 22 Mar 2013 13:03:13 -0400 In-Reply-To: <1363224194-7366-1-git-send-email-ynvich@gmail.com> (Sergey Yanovich's message of "Thu, 14 Mar 2013 05:23:13 +0400") Message-ID: <87620jmkoe.fsf@octavius.laptop.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1921 Lines: 54 Hi Sergey, On Wed, Mar 13 2013, Sergey Yanovich wrote: > MMC hosts are added asynchronously. We need to wait until detect returns to > avoid failed root filesystem mounts. > ---8<--- > VFS: Cannot open root device "mmcblk0p1" or unknown-block(0,0): error -6 > Please append a correct "root=" boot option; here are the available partitions: > mmc0: host does not support reading read-only switch. assuming write-enable. > 1f00 256 mtdblock0 (driver?) > 1f01 256 mtdblock1 (driver?) > 1f02 2560 mtdblock2 mmc0: new SDHC card at address b368 > (driver?) > 1f03 29696 mtdblock3 (driver?) > 1f04 16384 mtdblock4 mmcblk0: mmc0:b368 USD 3.72 GiB > (driver?) > mmcblk0: p1 > b300 3910656 mmcblk0 driver: mmcblk > b301 3906560 mmcblk0p1 00000000-01 > Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0) > ---8<--- > > Signed-off-by: Sergey Yanovich > --- > changes for v2: > - removed exporting as symbol is in the same file > > drivers/mmc/core/core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c > index aaed768..7196888 100644 > --- a/drivers/mmc/core/core.c > +++ b/drivers/mmc/core/core.c > @@ -2225,6 +2225,7 @@ void mmc_start_host(struct mmc_host *host) > host->rescan_disable = 0; > mmc_power_up(host); > mmc_detect_change(host, 0); > + mmc_flush_scheduled_work(); > } > > void mmc_stop_host(struct mmc_host *host) Thanks, this looks okay to me, I've pushed it to mmc-next for 3.10. - Chris. -- Chris Ball One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/