Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422898Ab3CVSSc (ORCPT ); Fri, 22 Mar 2013 14:18:32 -0400 Received: from mail-da0-f45.google.com ([209.85.210.45]:34536 "EHLO mail-da0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422814Ab3CVSS3 (ORCPT ); Fri, 22 Mar 2013 14:18:29 -0400 From: Kent Overstreet To: linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org Cc: Kent Overstreet , "J. Bruce Fields" , Al Viro , "Eric W. Biederman" , Zach Brown Subject: [PATCH] nfsd: fix bad offset use Date: Fri, 22 Mar 2013 11:18:24 -0700 Message-Id: <1363976304-26093-1-git-send-email-koverstreet@google.com> X-Mailer: git-send-email 1.8.1.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1493 Lines: 42 vfs_writev() updates the offset argument - but the code then passes the offset to vfs_fsync_range(). Since offset now points to the offset after what was just written, this is probably not what was intended Signed-off-by: Kent Overstreet Cc: "J. Bruce Fields" Cc: Al Viro Cc: "Eric W. Biederman" Cc: Zach Brown --- fs/nfsd/vfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index 2a7eb53..2b2e239 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c @@ -1013,6 +1013,7 @@ nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file, int host_err; int stable = *stablep; int use_wgather; + loff_t pos = offset; dentry = file->f_path.dentry; inode = dentry->d_inode; @@ -1025,7 +1026,7 @@ nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file, /* Write the data. */ oldfs = get_fs(); set_fs(KERNEL_DS); - host_err = vfs_writev(file, (struct iovec __user *)vec, vlen, &offset); + host_err = vfs_writev(file, (struct iovec __user *)vec, vlen, &pos); set_fs(oldfs); if (host_err < 0) goto out_nfserr; -- 1.8.1.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/