Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422827Ab3CVS2S (ORCPT ); Fri, 22 Mar 2013 14:28:18 -0400 Received: from www.sr71.net ([198.145.64.142]:34380 "EHLO blackbird.sr71.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422649Ab3CVS2R (ORCPT ); Fri, 22 Mar 2013 14:28:17 -0400 Message-ID: <514CA4EA.9030206@sr71.net> Date: Fri, 22 Mar 2013 11:37:30 -0700 From: Dave User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: "Kirill A. Shutemov" CC: Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2, RFC 21/30] x86-64, mm: proper alignment mappings with hugepages References: <1363283435-7666-1-git-send-email-kirill.shutemov@linux.intel.com> <1363283435-7666-22-git-send-email-kirill.shutemov@linux.intel.com> In-Reply-To: <1363283435-7666-22-git-send-email-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1318 Lines: 39 On 03/14/2013 10:50 AM, Kirill A. Shutemov wrote: > + if (filp) > + info.align_mask = mapping_can_have_hugepages(filp->f_mapping) ? > + PAGE_MASK & ~HPAGE_MASK : get_align_mask(); > + else > + info.align_mask = 0; > info.align_offset = pgoff << PAGE_SHIFT; > return vm_unmapped_area(&info); > } > @@ -174,7 +179,11 @@ arch_get_unmapped_area_topdown(struct file *filp, const unsigned long addr0, > info.length = len; > info.low_limit = PAGE_SIZE; > info.high_limit = mm->mmap_base; > - info.align_mask = filp ? get_align_mask() : 0; > + if (filp) > + info.align_mask = mapping_can_have_hugepages(filp->f_mapping) ? > + PAGE_MASK & ~HPAGE_MASK : get_align_mask(); > + else > + info.align_mask = 0; > info.align_offset = pgoff << PAGE_SHIFT; > addr = vm_unmapped_area(&info); > if (!(addr & ~PAGE_MASK)) how about static inline unsigned long mapping_align_mask(struct address_space *mapping) { if (mapping_can_have_hugepages(filp->f_mapping)) return PAGE_MASK & ~HPAGE_MASK; return get_align_mask(); } to replace these two open-coded versions? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/