Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751819Ab3CWRrP (ORCPT ); Sat, 23 Mar 2013 13:47:15 -0400 Received: from mail-ve0-f180.google.com ([209.85.128.180]:51296 "EHLO mail-ve0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751586Ab3CWRrO (ORCPT ); Sat, 23 Mar 2013 13:47:14 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Sat, 23 Mar 2013 10:47:13 -0700 X-Google-Sender-Auth: W_5F4wjUGTE2QvnSyUxYRc6HQ-Q Message-ID: Subject: Re: [PATCH 1/2] KMS: fix EDID detailed timing vsync parsing From: Linus Torvalds To: Torsten Duwe Cc: David Airlie , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 699 Lines: 18 On Sat, Mar 23, 2013 at 7:38 AM, Torsten Duwe wrote: > > EDID spreads some values across multiple bytes; bit-fiddling is needed > to retrieve these. The current code to parse "detailed timings" has a > cut&paste error that results in a vsync offset of at most 15 lines > instead of 63. Yeah, it clearly just mixes the bits together with that bitwise rather than actually spreading them out correctly. Applied. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/