Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751864Ab3CWSAN (ORCPT ); Sat, 23 Mar 2013 14:00:13 -0400 Received: from one.firstfloor.org ([193.170.194.197]:44768 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751673Ab3CWSAM (ORCPT ); Sat, 23 Mar 2013 14:00:12 -0400 Date: Sat, 23 Mar 2013 19:00:10 +0100 From: Andi Kleen To: Linus Torvalds Cc: Andi Kleen , Linux Kernel Mailing List , Andrew Morton , the arch/x86 maintainers , Benjamin Herrenschmidt Subject: Re: RFC: Kernel lock elision for TSX Message-ID: <20130323180010.GK20853@two.firstfloor.org> References: <1364001923-10796-1-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1287 Lines: 34 Hi Linux, Thanks. Other code/design review would be still appreciated, even under the current constraints. > The other comment I have is that since it does touch non-x86 header > files etc (although not a lot), you really need to talk to the POWER8 > people about naming of the thing. Calling it and having > "generic" helpers called _xtest() used by the generic spinlock code > sounds a bit suspect. I can make up another name for _xtest()/_xabort() and linux/rtm.h, (any suggestions?) The basic concepts implemented there should be pretty universal. If others have a equivalent of "is this a transaction" and "abort this tranction" they can just plug it in. Otherwise they will nop it, as it's only hints anyways. The only things used outside x86 code is _xtest()/_xabort(), can remove the rest from linux/*. Without transactions this is all nops. The primary interface for the lock code is the much higher level elide()/elide_lock_adapt() interface anyways. -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/