Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755674Ab3CYCZE (ORCPT ); Sun, 24 Mar 2013 22:25:04 -0400 Received: from server.atrad.com.au ([150.101.241.2]:57262 "EHLO server.atrad.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755590Ab3CYCZC (ORCPT ); Sun, 24 Mar 2013 22:25:02 -0400 Date: Mon, 25 Mar 2013 12:54:45 +1030 From: Jonathan Woithe To: Raymond Jennings Cc: Hillf Danton , David Rientjes , Linux-MM , LKML , Jonathan Woithe Subject: Re: OOM triggered with plenty of memory free Message-ID: <20130325022445.GH29157@marvin.atrad.com.au> References: <20130321070750.GV30145@marvin.atrad.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130321070750.GV30145@marvin.atrad.com.au> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1161 Lines: 33 This post ties up a few loose ends in this thread which remained after my 21 March 2013 post. * The memory leak was not present in 2.6.36. * The patch to 2.6.35.11 at the end of this email (based on 48e6b121605512d87f8da1ccd014313489c19630 from linux-stable) resolves the memory leak in 2.6.35.11. This gives us a workable solution while we await fixes to current mainline in the r8169 driver. Once that's done we can revalidate our systems against a more recent kernel and start shipping that. Thanks to those who assisted with this issue. Regards jonathan --- a/net/netlink/af_netlink.c 2013-03-25 10:32:15.365781434 +1100 +++ b/net/netlink/af_netlink.c 2013-03-25 10:32:15.373782107 +1100 @@ -1387,6 +1387,8 @@ static int netlink_sendmsg(struct kiocb err = netlink_unicast(sk, skb, dst_pid, msg->msg_flags&MSG_DONTWAIT); out: + scm_destroy(siocb->scm); + siocb->scm = NULL; return err; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/