Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757596Ab3CYGA6 (ORCPT ); Mon, 25 Mar 2013 02:00:58 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:39989 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755670Ab3CYGA4 (ORCPT ); Mon, 25 Mar 2013 02:00:56 -0400 Date: Mon, 25 Mar 2013 09:00:38 +0300 From: Dan Carpenter To: wei_wang@realsil.com.cn Cc: cjb@laptop.org, sameo@linux.intel.com, gregkh@linuxfoundation.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, rogerable@realtek.com, devel@linuxdriverproject.org Subject: Re: [PATCH] mfd:rtsx: Support RTS5249 Message-ID: <20130325060038.GD9138@mwanda> References: <1364177636-4294-1-git-send-email-wei_wang@realsil.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1364177636-4294-1-git-send-email-wei_wang@realsil.com.cn> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 719 Lines: 24 On Mon, Mar 25, 2013 at 10:13:56AM +0800, wei_wang@realsil.com.cn wrote: > +static int rts5249_optimize_phy(struct rtsx_pcr *pcr) > +{ > + int err; > + > + err = rtsx_pci_write_phy_register(pcr, 0x19, 0xFE46); > + if (err < 0) > + return err; > + > + mdelay(1); Why do we have the mdelay() and the later msleep(5)? rtsx_pci_write_phy_register() busy loops until the write succeeds or it returns -ETIMEOUT. The extra wait here seems unnecessary. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/