From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Doug Anderson'" <dianders@chromium.org>
Cc: "'Thomas Abraham'" <thomas.abraham@linaro.org>,
        "'Stephen Warren'" <swarren@nvidia.com>,
        "'Changhwan Youn'" <chaos.youn@samsung.com>,
        "'Arnd Bergmann'" <arnd@arndb.de>, "'Olof Johansson'" <olof@lixom.net>,
        "'Simon Glass'" <sjg@chromium.org>,
        "'John Stultz'" <john.stultz@linaro.org>,
        "'Thomas Gleixner'" <tglx@linutronix.de>, linux-kernel@vger.kernel.org
References: <1363967587-19154-1-git-send-email-dianders@chromium.org>
In-reply-to: <1363967587-19154-1-git-send-email-dianders@chromium.org>
Subject: RE: [PATCH] ARM: EXYNOS: Add missing semicolons in exynos_mct.c
Date: Mon, 25 Mar 2013 18:50:40 +0900
Message-id: <177201ce293e$35753cf0$a05fb6d0$%kim@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
Thread-index: Ac4nFYzHc5cbeMU/TPm/xNx7B7wcdwB5fXaw
Content-language: ko
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1699
Lines: 49

Doug Anderson wrote:
> 
> The CLOCKSOURCE_OF_DECLARE lines were added without a semicolon at the
> end.  On my system this causes a compile-time error that looks like:
> 
>  .../drivers/clocksource/exynos_mct.c:557:202: warning: comparison of
> distinct pointer types lacks a cast [enabled by default]
>  .../drivers/clocksource/exynos_mct.c:558:1: error: expected ',' or ';'
> before 'static'
> 
> The error didn't show up till now because there was an extra semicolon

Yeah.

> at end of the CLOCKSOURCE_OF_DECLARE definition that was removed by
> Arnd Bergmann in "clocksource: make CLOCKSOURCE_OF_DECLARE type safe"
> 
OK, thanks.

> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
>  drivers/clocksource/exynos_mct.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clocksource/exynos_mct.c
> b/drivers/clocksource/exynos_mct.c
> index 203ac05..106228d 100644
> --- a/drivers/clocksource/exynos_mct.c
> +++ b/drivers/clocksource/exynos_mct.c
> @@ -554,5 +554,5 @@ void __init mct_init(void)
>  	exynos4_clocksource_init();
>  	exynos4_clockevent_init();
>  }
> -CLOCKSOURCE_OF_DECLARE(exynos4210, "samsung,exynos4210-mct", mct_init)
> -CLOCKSOURCE_OF_DECLARE(exynos4412, "samsung,exynos4412-mct", mct_init)
> +CLOCKSOURCE_OF_DECLARE(exynos4210, "samsung,exynos4210-mct", mct_init);
> +CLOCKSOURCE_OF_DECLARE(exynos4412, "samsung,exynos4412-mct", mct_init);
> --
> 1.8.1.3

Applied, thanks.

- Kukjin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/