From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Axel Lin'" <axel.lin@ingics.com>
Cc: "'Thomas Gleixner'" <tglx@linutronix.de>,
        "'John Stultz'" <john.stultz@linaro.org>,
        "'Thomas Abraham'" <thomas.abraham@linaro.org>,
        "'Changhwan Youn'" <chaos.youn@samsung.com>,
        linux-kernel@vger.kernel.org
References: <1364048887.13141.0.camel@phoenix>
 <16f801ce28f5$b9095c20$2b1c1460$%kim@samsung.com>
 <CAFRkauCDg9G3JLpB+fi3JZdu-18jr0ibFqM30tOH4rPQVO8dUQ@mail.gmail.com>
In-reply-to: <CAFRkauCDg9G3JLpB+fi3JZdu-18jr0ibFqM30tOH4rPQVO8dUQ@mail.gmail.com>
Subject: RE: [PATCH] clocksource: exynos_mct: Add terminating entry for
 exynos_mct_ids table
Date: Mon, 25 Mar 2013 19:13:26 +0900
Message-id: <177901ce2941$63c85710$2b590530$%kim@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
Thread-index: Ac4o9q4zcsaogIcPS6eqcVUkCjj7IgASmcRw
Content-language: ko
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1614
Lines: 49

Axel Lin wrote:
> 
> 2013/3/25 Kukjin Kim <kgene.kim@samsung.com>:
> > Axel Lin wrote:
> >>
> >> The of_device_id table is supposed to be zero-terminated.
> >>
> >> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> >> ---
> >>  drivers/clocksource/exynos_mct.c |    1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/clocksource/exynos_mct.c
> >> b/drivers/clocksource/exynos_mct.c
> >> index 203ac05..3cdafc0 100644
> >> --- a/drivers/clocksource/exynos_mct.c
> >> +++ b/drivers/clocksource/exynos_mct.c
> >> @@ -514,6 +514,7 @@ static void __init exynos4_timer_resources(struct
> >> device_node *np)
> >>  static const struct of_device_id exynos_mct_ids[] = {
> >>       { .compatible = "samsung,exynos4210-mct", .data = (void
> >> *)MCT_INT_SPI },
> >>       { .compatible = "samsung,exynos4412-mct", .data = (void
> >> *)MCT_INT_PPI },
> >> +     { }
> >
> > Thanks for your pointing out. But as I know, it is not mandatory now.
> >
> > Please correct me if I'm wrong.
> 
> of_find_matching_node_and_match()
> -> __of_match_node()
>     while (matches->name[0] || matches->type[0] || matches->compatible[0])
> 
> My understanding is the implementation in _of_match_node() still needs
> zero-terminated entry to break out the while loop.

OK, you're right. In this case, a null entry is required in
__of_match_node().

Thanks, applied.

- Kukjin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/