Date: Mon, 25 Mar 2013 06:34:10 -0600
From: Jens Axboe <axboe@kernel.dk>
To: Tanya Brokhman <tlinder@codeaurora.org>
Cc: linux-mmc@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        Alex.Lemberg@sandisk.com, open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 1/3] block: Add support for reinsert a dispatched req
Message-ID: <20130325123410.GG22327@kernel.dk>
References: <1364202150-8776-1-git-send-email-tlinder@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1364202150-8776-1-git-send-email-tlinder@codeaurora.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1227
Lines: 28

On Mon, Mar 25 2013, Tanya Brokhman wrote:
> From: Tatyana Brokhman <tlinder@codeaurora.org>
> 
> Add support for reinserting a dispatched request back to the
> scheduler's internal data structures.
> This capability is used by the device driver when it chooses to
> interrupt the current request transmission and execute another (more
> urgent) pending request. For example: interrupting long write in order
> to handle pending read. The device driver re-inserts the
> remaining write request back to the scheduler, to be rescheduled
> for transmission later on.
> 
> Add API for verifying whether the current scheduler
> supports reinserting requests mechanism. If reinsert mechanism isn't
> supported by the scheduler, this code path will never be activated.

This is practically the exact same operation as a requeue. So why this
duplication? I also don't quite understand why an IO scheduler would
have to opt-in for this, seems like a pretty basic operation.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/