Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757618Ab3CYNEU (ORCPT ); Mon, 25 Mar 2013 09:04:20 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50572 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753297Ab3CYNET (ORCPT ); Mon, 25 Mar 2013 09:04:19 -0400 Date: Mon, 25 Mar 2013 14:04:16 +0100 From: Michal Hocko To: Naoya Horiguchi Cc: linux-mm@kvack.org, Andrew Morton , Mel Gorman , Hugh Dickins , KOSAKI Motohiro , Andi Kleen , Hillf Danton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/10] migrate: add hugepage migration code to migrate_pages() Message-ID: <20130325130416.GV2154@dhcp22.suse.cz> References: <1363983835-20184-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1363983835-20184-6-git-send-email-n-horiguchi@ah.jp.nec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1363983835-20184-6-git-send-email-n-horiguchi@ah.jp.nec.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1554 Lines: 52 On Fri 22-03-13 16:23:50, Naoya Horiguchi wrote: [...] > @@ -523,6 +544,11 @@ static inline int check_pmd_range(struct vm_area_struct *vma, pud_t *pud, > pmd = pmd_offset(pud, addr); > do { > next = pmd_addr_end(addr, end); > + if (pmd_huge(*pmd) && is_vm_hugetlb_page(vma)) { > + check_hugetlb_pmd_range(vma, pmd, nodes, > + flags, private); I am afraid this has the same issue with other huge page sizes I have mentioned earlier. > + continue; > + } > split_huge_page_pmd(vma, addr, pmd); > if (pmd_none_or_trans_huge_or_clear_bad(pmd)) > continue; [...] > @@ -1012,14 +1040,8 @@ static int migrate_to_node(struct mm_struct *mm, int source, int dest, > check_range(mm, mm->mmap->vm_start, mm->task_size, &nmask, > flags | MPOL_MF_DISCONTIG_OK, &pagelist); > > - if (!list_empty(&pagelist)) { > - err = migrate_pages(&pagelist, new_node_page, dest, > + return migrate_movable_pages(&pagelist, new_node_page, dest, > MIGRATE_SYNC, MR_SYSCALL); > - if (err) > - putback_lru_pages(&pagelist); > - } > - > - return err; This is really confusing. Why migrate_pages doesn't do putback cleanup on its own but migrate_movable_pages does? Please also move migrate_movable_pages definition to this patch. > } > > /* > -- > 1.7.11.7 > -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/