Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758688Ab3CYQ1z (ORCPT ); Mon, 25 Mar 2013 12:27:55 -0400 Received: from mail.free-electrons.com ([94.23.35.102]:47957 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758576Ab3CYQ1x (ORCPT ); Mon, 25 Mar 2013 12:27:53 -0400 Message-ID: <51507B07.4050204@free-electrons.com> Date: Mon, 25 Mar 2013 17:27:51 +0100 From: Maxime Ripard User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: Rob Herring CC: linux-arm-kernel@lists.infradead.org, shuge@allwinnertech.com, linux-kernel@vger.kernel.org, Russell King , kevin@allwinnertech.com, sunny@allwinnertech.com Subject: Re: [PATCH 08/10] ARM: sunxi: dt: Update interrupt controller compatible string References: <1364218233-29636-1-git-send-email-maxime.ripard@free-electrons.com> <1364218233-29636-9-git-send-email-maxime.ripard@free-electrons.com> <51505825.2060805@gmail.com> In-Reply-To: <51505825.2060805@gmail.com> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1637 Lines: 48 Hi Rob, Le 25/03/2013 14:59, Rob Herring a ?crit : > On 03/25/2013 08:30 AM, Maxime Ripard wrote: >> Signed-off-by: Maxime Ripard >> --- >> arch/arm/boot/dts/sun4i-a10.dtsi | 2 +- >> arch/arm/boot/dts/sun5i-a13.dtsi | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi >> index be71782..805d704 100644 >> --- a/arch/arm/boot/dts/sun4i-a10.dtsi >> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi >> @@ -121,7 +121,7 @@ >> ranges; >> >> intc: interrupt-controller@01c20400 { >> - compatible = "allwinner,sunxi-ic"; >> + compatible = "allwinner,sun4i-ic"; > > Generally speaking, this is a bad thing to do. This breaks compatibility > between dtb and kernel versions. If that breakage is not yet a concern > for sunxi, then it is okay. Yes, I know, but I thought it was okay since sunxi has never been in an usable state, and it seemed odd to me to begin to maintain an history for a platform that has never actually been booted by a user. On the other end, if someone speaks up, I'd be happy to keep the old compatible around as well. > Also, I don't see any documentation updates for any of these changes. Ah, yes, my bad. Thanks, Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/